[Koha-bugs] [Bug 15985] Include transacting library in fines

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #10 from Josef Moravec <josef.moravec at gmail.com> ---
Kyle, I still found some issues with this:

1. reported by QA tools, not sure how to fix this..., :
 FAIL   Koha/Old/Checkout.pm
   FAIL   valid
                        merging failed on 'Koha::Checkout' 
                        ]
                                Koha::Old::Checkout,
                        current merge results [
                Inconsistent hierarchy during C3 merge of class
'Koha::Old::Checkout':


2. This still remains:
 FAIL   Koha/Checkout.pm
  FAIL    pod
                 in file Koha/Checkout.pm
                Unknown command 'head'
                *** ERROR: 
   FAIL   pod coverage
                POD is missing for 'library'

you should use =head3 I think

3. The code added to Koha/Schema/Result/OldIssue.pm should be after schema
loader mark

4. Also, when you make Koha::Checkout base for Koha::Old::Checkout, you should
also define relations 'borrower' and 'item' in Koha::Schema::OldIssue

-- 
You are receiving this mail because:
You are watching all bug changes.