[Koha-bugs] [Bug 18725] Process_message_queue sends duplicate emails if message_queue is not writable

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Apr 6 11:17:04 CEST 2018


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73277|0                           |1
        is obsolete|                            |
  Attachment #73278|0                           |1
        is obsolete|                            |

--- Comment #20 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 73749
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73749&action=edit
Bug 18725 - Process_message_queue sends duplicate emails if message_queue is
not writable.

Last week, we had a database server whose disk filled, causing database writes
to fail.

This meant that messages in message_queue marked 'pending' were not marked as
'sent' when they were added to the postfix mail queue; messages were sent every
15 minutes (as specified in the cron job) until the disk space issues were
cleared.

I would suggest adding a token write to the start of process_message_queue.pl
as a 'canary in the coal mine'. If the database write fails,
process_message_queue should stop, because it's not safe to proceed sending
emails that may not be marked 'sent'.

Test Plan:
1) Apply this patch
2) Make the message_queue table unwriteable somehow
3) Run process_message_queue.pl
4) Script should die with error

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list