[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #143 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Comment on attachment 72574
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72574
Bug 18606: Database changes - Add foreign keys to collections_tracking

Review of attachment 72574:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18606&attachment=72574)
-----------------------------------------------------------------

::: installer/data/mysql/kohastructure.sql
@@ +969,5 @@
> +  PRIMARY KEY (collections_tracking_id)
> +) ENGINE=InnoDB  DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci;
> +
> +ALTER TABLE `collections_tracking`
> +  ADD CONSTRAINT `collections_tracking_ibfk_1` FOREIGN KEY (`colId`) REFERENCES `collections` (`colId`) ON DELETE CASCADE ON UPDATE CASCADE;

Why did add constraints separatly from the table creation? It seems to me that
it is less readable for people wanting to quickly get the structure of the
table.

@@ +973,5 @@
> +  ADD CONSTRAINT `collections_tracking_ibfk_1` FOREIGN KEY (`colId`) REFERENCES `collections` (`colId`) ON DELETE CASCADE ON UPDATE CASCADE;
> +
> +ALTER TABLE `collections_tracking`
> +  ADD CONSTRAINT `collections_tracking_ibfk_2` FOREIGN KEY (`itemnumber`) REFERENCES `items` (`itemnumber`) ON DELETE CASCADE ON UPDATE CASCADE;
> +

idem

-- 
You are receiving this mail because:
You are watching all bug changes.