[Koha-bugs] [Bug 20122] Empty and close link on cart page not working (js security)

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20122

Roch D'Amour <roch.damour at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73790|0                           |1
        is obsolete|                            |

--- Comment #10 from Roch D'Amour <roch.damour at inlibro.com> ---
Created attachment 73803
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73803&action=edit
Bug 20122: Empty lists keep coming back

This is caused by bib_list not being deleted.
The path was not explicitly set.
This patch adds path=/ explicitly to ensure it
does get deleted.

TEST PLAN
---------
1) search for 'the' in OPAC
2) add several items to cart.
3) look at your cart.
4) empty and close the cart, select all->remove
   -- either way window closes and it looks empty.
5) refresh the page
   -- cart comes back.
   -- in chromium inspecting the page, specifically
      the "Application" area, bib_list is shown as
      a cookie still.
6) apply patch
7) restart_all and empty cache forcing JS reload
8) repeat steps 1-5
   -- this time cart stays empty.
   -- and the bib_list cookie is gone

Signed-off-by: Roch D'Amour <roch.damour at inlibro.com> using firefox 59.0.2

-- 
You are receiving this mail because:
You are watching all bug changes.