[Koha-bugs] [Bug 20538] Remove the need of writing [% KOHA_VERSION %] everywhere
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Sun Apr 8 12:52:20 CEST 2018
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20538
Julian Maurice <julian.maurice at biblibre.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #73791|0 |1
is obsolete| |
--- Comment #3 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 73836
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73836&action=edit
Bug 20538: Remove the need of writing [% KOHA_VERSION %] everywhere
Having to write [% KOHA_VERSION %] for each url is bad because:
- It's easily forgettable when adding new <script> or <link>
- It prevents grep'ing for the full filename
- It violates the DRY principle
- If at some point we want to change the "force js and css reload"
mechanism, it will be tedious
This patch:
- adds a Template::Toolkit plugin that generates <script> and
<link> tags for JS and CSS files, and inserts automatically the Koha
version in the filename
- use the new plugin to remove all occurences of [% KOHA_VERSION %]
- remove the code that was adding KOHA_VERSION as a template variable
Test plan:
1. Apply patch
2. Go to several different pages in Koha (opac and intranet) while
checking your browser's dev tools (there should be no 404 for JS and
CSS files, and the Koha version should appear in filenames) and the
server logs (there should be no "File not found")
3. `git grep KOHA_VERSION` should return nothing
4. prove t/db_dependent/Koha/Template/Plugin/Asset.t
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list