[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #45 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Comment on attachment 70918
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70918
Bug 19287: Add ability to mark an item 'Lost' from 'Holds to pull' list

Review of attachment 70918:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19287&attachment=70918)
-----------------------------------------------------------------

Hi Jonathan, 

I'll add a see also to bug 19974 - might need a follow-up depending on it.

>QA Notes:
>From which library do we want to pick the notice? This patch use
>reserves.branchcode
_send_message_by_email will be using the homebranch of the library for getting
the right return-path and reply-to addresses for the email. I think instead of
the pick-up library i'd use the homebranch of the patron to make it all match.

1) Please add the new notice to the different installers for new installations.
2) New action column is not in column visibility settings. I think for print it
might make sense that someone wants to hide it from display.

::: installer/data/mysql/atomicupdate/bug_19287.sql
@@ +1,3 @@
> +INSERT IGNORE INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `type` ) VALUES ('CanMarkHoldsToPullAsLost','do_not_allow','do_not_allow|allow|allow_and_notify','Add a button to the "Holds to pull" screen to mark an item as lost and notify the patron.','Choice');
> +
> +INSERT IGNORE INTO letter(module, code, branchcode, name, is_html, title, content, message_transport_type, lang) VALUES ('reserves', 'CANCEL_HOLD_ON_LOST', '', 'Hold has been cancelled', 0, "Hold has been cancelled", "Dear [% borrower.firstname %] [% borrower.surname %],\n\nWe regret to inform you that the following item cannot longer be placed on hold, it has been marked as lost\n\nTitle: [% biblio.title %]\nAuthor: [% biblio.author %]\nCopy: [% item.copynumber %]\nLocation: [% branch.branchname %]", 'email', 'default');

3) I think maybe:
We regret to inform you, that the following item can not be provided due to it
being missing. Your hold was cancelled.

::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
@@ +712,5 @@
> +        -
> +            - Update item's values when marked as lost from the hold to pull screen
> +            - pref: UpdateItemWhenLostFromHoldList
> +              type: textarea
> +            - This is a list of values to update an item when it is marked as lost from the holds to pull screen.

4) I think it would be good to give an example here for the syntax. I am not
sure how to set it and to test it. And I think have all the text above the
input field.

::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt
@@ +34,5 @@
> +                    <span>There is no notice template with a code 'CANCEL_HOLD_ON_LOST' defined in your system.</span>
> +                [% CASE 'hold_cancelled' %]
> +                    <span>The hold has been correctly cancelled.</span>
> +                [% CASE 'hold_placed_at_biblio_level' %]
> +                    <span>The hold has been placed at biblio level. It is not possible to mark it as lost.</span>

5) Maybe we should not display the button in this case?
The hold has been placed on biblio level. It is not possible to determine the
item to mark as lost. (the it in the second sentence refers to hold for me, and
you can't mark holds lost)

@@ +125,5 @@
> +                    <input type="hidden" name="op" value="mark_as_lost" />
> +                    <input type="submit" value="Mark item as lost" />
> +                [% ELSIF Koha.Preference('CanMarkHoldsToPullAsLost') == 'allow_and_notify' %]
> +                    <input type="hidden" name="op" value="mark_as_lost_and_notify" />
> +                    <input type="submit" value="Mark item as lost and notify the patron" />

6) Mark lost and notify patron (shorter for the button)

-- 
You are receiving this mail because:
You are watching all bug changes.