[Koha-bugs] [Bug 14567] Browse interface for OPAC

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567

--- Comment #38 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Comment on attachment 69614
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69614
Bug 14567: Add a browse interface to the OPAC

Review of attachment 69614:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14567&attachment=69614)
-----------------------------------------------------------------

It's quite basic still, but that makes it easy to test and it's really fast on
my system.

Some mostly small things that should be easy to check/fix:

1) There is currently no way to access the page from the OPAC if you don't know
the address. Should we not add it to the top navigation? Maybe with an id to
make it easy to hide?
2) Will long lists be paged? I couldn't get it to page on my system but wonder
how it will look for a really long list.

::: Koha/SearchEngine/Elasticsearch/Browse.pm
@@ +178,5 @@
> +=head1 AUTHOR
> +
> +=over 4
> +
> +=item Robin Sheat C<< <robin at catalyst.net.nz> >>

5) Was the C intentional?

::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-browse.tt
@@ +83,5 @@
> +    </div><!-- / .container-fluid -->
> +</div><!-- / .main -->
> +[% INCLUDE 'opac-bottom.inc' %]
> +[% BLOCK jsinclude %]
> +<script type="text/javascript" src="[% interface %]/[% theme %]/js/browse.js">

3) FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-browse.tt
   FAIL   forbidden patterns
                forbidden pattern: Include [% KOHA_VERSION %] in js paths (bug
12904) - May be false positive (line 87)

Not a false one here I think!

::: opac/opac-browse.pl
@@ +91,5 @@
> +    );
> +    print to_json( \@output );
> +}
> +
> +# This is a temporary, MARC21-only thing that will grab titles, and authors

4) Still MARC21 only?

-- 
You are receiving this mail because:
You are watching all bug changes.