[Koha-bugs] [Bug 19817] Merge local and online documentations

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #25 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 73525
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73525
Bug 19817: Make the location of the manual configurable - KohaManualBaseURL

Review of attachment 73525:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19817&attachment=73525)
-----------------------------------------------------------------

The http URL redirects to an https one, so it makes more sense to use https
immediately.

::: help.pl
@@ +39,2 @@
>  # FIXME /en/ must be configurable (or guessed)
> +my $KohaManualBaseURL = C4::Context->preference('KohaManualBaseURL') || 'http://koha-community.org/manual';

please use https.

::: installer/data/mysql/atomicupdate/bug_19817.sql
@@ +1,2 @@
> +INSERT IGNORE INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `type` )
> +VALUES ('KohaManualBaseURL','http://koha-community.org/manual/','','Where is the Koha manual/documentation located?','Free');

please use https.

::: installer/data/mysql/sysprefs.sql
@@ +238,4 @@
>  ('itemBarcodeInputFilter','','whitespace|T-prefix|cuecat|libsuite8|EAN13','If set, allows specification of a item barcode input filter','Choice'),
>  ('itemcallnumber','082ab',NULL,'The MARC field/subfield that is used to calculate the itemcallnumber (Dewey would be 082ab or 092ab; LOC would be 050ab or 090ab) could be 852hi from an item record','free'),
>  ('KohaAdminEmailAddress','root at localhost','','Define the email address where patron modification requests are sent','free'),
> +('KohaManualBaseURL','http://koha-community.org/manual/','','Where is the Koha manual/documentation located?','Free'),

please use https.

:::
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/enhanced_content.pref
@@ +394,5 @@
> +    Manual:
> +        -
> +            - Location of the Koha manual
> +            - pref: KohaManualBaseURL
> +            - You can specify the location of the Koha manual to use. By default it is http://koha-community.org/manual/

please use https.

-- 
You are receiving this mail because:
You are watching all bug changes.