[Koha-bugs] [Bug 18725] process_message_queue.pl sends duplicate emails if message_queue is not writable

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725

--- Comment #26 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #25)
> (In reply to Marcel de Rooy from comment #24)
> > (In reply to Jonathan Druart from comment #23)
> > > Why not simply:
> > > 
> > >   return unless $message_object->status('pending')->store;
> > 
> > That does not trigger an update unless you mark a field as 'dirty' (a DBIx
> > method that is not supported by Koha::Object and is not passed thru either).
> 
> Indeed, but... the tests pass with this change.

Yeah, we are testing if sub { return; } indeed returns undef ;)
So the test could perhaps be improved. Writing to a readonly database, or
whatever? No blocker for me though..

-- 
You are receiving this mail because:
You are watching all bug changes.