[Koha-bugs] [Bug 20538] Remove the need of writing [% KOHA_VERSION %] everywhere

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20538

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #12 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Katrin Fischer from comment #9)
> There are some FAILs in the QA script, but I assume they are just side
> effects/false positives for this patch. Maybe something to look into later:
> 
>  FAIL	koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-MARCdetail.tt
>    FAIL	  forbidden patterns
> 		forbidden pattern: opac-tmpl should certainly replaced with [% interface
> %] (line 67)
>    OK	  git manipulation
>    OK	  spelling
>    OK	  tt_valid
>    OK	  valid_template
> 
>  FAIL	koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-detail.tt
>    FAIL	  forbidden patterns
> 		forbidden pattern: opac-tmpl should certainly replaced with [% interface
> %] (line 132)
>    OK	  git manipulation
>    OK	  spelling
>    OK	  tt_valid
>    OK	  valid_template
> ...
These ones are true positives. Fixed in the last patch

> 
> 1) Is the copyright statement correct?
> +package Koha::Template::Plugin::Asset;
> +
> +# Copyright Marc Véron / marc veron ag, Switzerland
> 
> 2) Not blocker, but a note: Need to update qa tools!
> 
> Can you quickly check 1) please?
Done. Thanks for catching that.

-- 
You are receiving this mail because:
You are watching all bug changes.