[Koha-bugs] [Bug 19882] Add Novelist Select staff client profile

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19882

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Comment on attachment 72918
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72918
Bug 19882 - Add Novelist Select staff client profile

Review of attachment 72918:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19882&attachment=72918)
-----------------------------------------------------------------

::: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
@@ +1025,5 @@
>              verify_images();
>          });[% END %]
>      </script>
> +    [% IF ( Koha.Preference('NovelistSelectStaffEnabled') && Koha.Preference('NovelistSelectStaffProfile') && ( normalized_isbn || normalized_upc ) ) %]
> +        <script type="text/javascript" src="https://imageserver.ebscohost.com/novelistselect/ns2init.js"></script>

External Javascript, so this is ok.

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
   FAIL   forbidden patterns
                forbidden pattern: Include [% KOHA_VERSION %] in js paths (bug
12904) - May be false positive (line 1049)

-- 
You are receiving this mail because:
You are watching all bug changes.