[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123

--- Comment #33 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #32)
> I'd like your opinions on this alternative patch.

Your patch will definitely fix any issues with malformed html, but it doesn't
check to see if the notices *is* html, does it? Also, it feels like just
another band-aid to me. Using an iframe completely sandboxes the message html
so it will protect the page from problems that we haven't anticipated. It also
adds more overhead since it is not doing xml processing on each notice a patron
has.

-- 
You are receiving this mail because:
You are watching all bug changes.