[Koha-bugs] [Bug 2505] Omnibus: Enable Perl warnings in all modules and scripts

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2505

Barton Chittenden <barton at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |barton at bywatersolutions.com

--- Comment #29 from Barton Chittenden <barton at bywatersolutions.com> ---
Just to see what happens, I enabled warnings in C4/Reserves.pm. All of the
warnings were of the form

Subroutine * redefined at C4/Reserves.pm line *.

This is happening because of circular dependencies, e.g. 


C4/Reserves.pm uses

C4::Members
C4::Circulation

Those modules in turn use C4::Reserves. None of the functions used in these
modules is actually called in C4::Reserves, but removing the calls to
C4::Members and C4::Circulation from C4/Reserves.pm isn't enough, apparently
there's a deeper circular dependency there.

I suspect that there are a number of unnecessary 'use' statements peppered
throughout the C4 namespace; cleaning those up might fix the problem entirely,
or at least allow us to resolve any remaining dependencies easily.

-- 
You are receiving this mail because:
You are watching all bug changes.