[Koha-bugs] [Bug 20592] updateitem.pl causes database errors when empty non-public item notes updated

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20592

--- Comment #5 from M. Tompsett <mtompset at hotmail.com> ---
Test plan is the same as comment #1.
Testing on a kohadevbox after a reset all.
blanking the log before clicking update:
 echo | sudo tee /var/log/koha/kohadev/plack-error.log
Used the same url given:

http://localhost:8081/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=1&itemnumber=1

Before my two patches, noise and update triggers more.
After my two patches, no noise.

David's patch works, but if there are other places which need the same check
they would have to be modified too. The ModItem function should be validating
its parameters. Also, I don't believe you need to check for biblionumber in
your condition, David.

My first patch adds that validation, so other functions receive the same fix.
My second just cleans up some noise, since the first warning wasn't the only
noise triggered.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.