[Koha-bugs] [Bug 13937] Add a Z39.50 daemon that can inject item status MARC subfields

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #43 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
=== Details
Net::Z3950::SimpleServer
Just wondering why we need a new dep. SIPServer uses Net::Server::PreFork ?

t/Koha/Z3950responder.t
This test fails with me. Please check.
not ok 3 - We didn't start server , should fail
#   Failed test 'We didn't start server , should fail'
#   at t/Koha/Z3950responder.t line 24.
#          got: undef
#     expected: '2'
not ok 4 - We didn't start server, should fail because it cannot connect
#   Failed test 'We didn't start server, should fail because it cannot connect'
#   at t/Koha/Z3950responder.t line 25.
#          got: undef
#     expected: 'Cannot connect to upstream server'
not ok 5 - There is no handler as we aren't connected
#   Failed test 'There is no handler as we aren't connected'
#   at t/Koha/Z3950responder.t line 27.
#          got: '13'
#     expected: '30'
not ok 6 - We don't have a handler, should fail because we don't
#   Failed test 'We don't have a handler, should fail because we don't'
#   at t/Koha/Z3950responder.t line 28.
#          got: 'Fetch request out of range'
#     expected: 'No such resultset'
Use of uninitialized value $num_to_prefetch in division (/) at
/usr/share/koha/devclone/Koha/Z3950Responder/Session.pm line 158.
Illegal division by zero at
/usr/share/koha/devclone/Koha/Z3950Responder/Session.pm line 158.

t/db_dependent/Koha/Z3950Responder/Session.t
t/db_dependent/Koha/Z3950Responder/Session2.t
The test coverage only focuses on the add item status routine. We are not
testing the server itself. Would it be too hard to try?

Commit message stuff from qa tools
        * Commit title does not contain 'follow-up' correctly spelt - 8e0da10
        * Commit title does not start with 'Bug XXXXX: ' - 31c0f7b
        * Commit title does not start with 'Bug XXXXX: ' - cf4f62b
        * Commit title does not contain 'follow-up' correctly spelt - cf4f62b
        * Commit title does not start with 'Bug XXXXX: ' - f592650
        * Commit title does not contain 'follow-up' correctly spelt - f592650
        * Commit title does not start with 'Bug XXXXX: ' - c24c232

Path::Tiny
Why is this dependency added? It is not used somewhere.

Log::Log4perl::Appender
Might be a new enhancement on itself?? 

my ($item_tag, $itemnumber_subfield) = GetMarcFromKohaField(
"items.itemnumber", '' );
Does not need the default framework parameter anymore. See changed API.

Testing misc/z3950_responder.pl
Crashes on show 0
Can't call method "raw" on an undefined value at
/usr/share/koha/devclone/Koha/Z3950Responder/Session.pm line 169.
Target closed connection

+    warn "name: $opt_name and value: $opt_value";
Debug leftover?

Configuration
Defaults to port 9999 (yaz default). Note that we may use port 9999 too for
Zebra authorities.. Passing a listener-address worked though.
Should we add our own default?

-- 
You are receiving this mail because:
You are watching all bug changes.