[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think that might be some underdocumented feature here that doesn't work in
all cases. 

The message is set by ReturnLostItem:
http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/Circulation.pm;hb=95031b035b5de87211d0de2040eb685ae005606c#l3601

ReturnLostItem is only used by pay (at least in master):

http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=Koha/Account.pm;hb=95031b035b5de87211d0de2040eb685ae005606c#l114

Then there is also the template:
http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt;hb=95031b035b5de87211d0de2040eb685ae005606c#l237

So when a fine of type L or Rep is paid, the line will be added to
items.paidfor.

Of course this is problematic in multiple ways:
- the whole note is untranslatable
- we store firstname surname and not the borrowernumber, which can lead to
confusion with common names.
- we store a badly formatted date (note the missing leading zeros) in ISO
format.

We could fix the behaviour and only add the note for payments (not write offs).
But maybe we should rethink the whole thing? Is this information really helpful
when you can get it from the cleaned up accountlines and account_offsets table
now in a clean way?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.