[Koha-bugs] [Bug 19855] Move the "alert" code to Koha::Subscription

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Sun Apr 22 11:46:43 CEST 2018


Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
  Attachment #74615|0                           |1
        is obsolete|                            |

--- Comment #22 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 74692
Bug 19855: Move getalert, addalert and delalert to Koha::Subscription

This patch removes 3 subroutines from C4::Letters:
- getalert
- addalert
- delalert

And add 3 methods to Koha::Subscription:
- subscribers
- add_subscriber
- remove_subscriber

It makes the code cleaner for future cleanup.
TODO - we should remove alert.alertid and alert.type, and rename
alert.externalid with alert.subscriptionid
That way alert will be renamed borrowers_subscriptions (or similar) and
will become a simple join table between borrowers and subscriptions.
We will need to deal with FK that could not be satisfied.
Let's do that after this patch is pushed.

Test plan:
Subscribe and unsubscribe to email notifications sent when a new issues
is available.
Make sure everything works as before and you receive the emails.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

You are receiving this mail because:
You are watching all bug changes.

More information about the Koha-bugs mailing list