[Koha-bugs] [Bug 9302] Add ability to merge patron records

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302

--- Comment #62 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #60)
> (In reply to Kyle M Hall from comment #55)
> > (In reply to Jonathan Druart from comment #54)
> > > Thanks for the follow-ups.
> > > 
> > > (In reply to Jonathan Druart from comment #38)
> > > > 1. How did you generate $RESULTSET_PATRON_ID_MAPPING?
> > > > How are we going to keep it up-to-date?
> > 
> > I went through the tables looking for columns that represent
> > borrowernumbers. It's pretty easy for columns with foreign keys to
> > borrowers.borrowernumber, but not all the columns have a borrowernumber. We
> > should just add that to the qa process. If a new column is added that is a
> > borrowernumber, it should be added to the mapping. We could move the mapping
> > itself its own perl module to make it more obvious if you wish.
> 
> I am going to push as it but I am not convinced by this approach.
> We will not have any tests to alert us if we forgot to update this mapping.

I'm sure we can do two things with unit tests:
1) Automate checking that all borrowernumber fields that are foreign keys to
borrowers.borrowernumber are in our mapping
2) Automate testing all non-fk fields that are *named* borrowernumber are in
our mapping.

As for non-fk fields that are not named bororwernumber, I don't think there is
anything we can do.

-- 
You are receiving this mail because:
You are watching all bug changes.