[Koha-bugs] [Bug 20100] Should a non-superlibrarian be able to add superlibrarian privileges?

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100

--- Comment #27 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Nick Clemens from comment #25)
> All looks good to me, the trick of enabling the button on submit didn't feel
> right though.
> 
> I attached an alternate patch that changes the form, adding a hidden input
> for when the button is disabled. It forced a few more js changes, but I like
> the concept better.
> 
> Can you weigh in Marcel and either SO or obsolete my patch? you can then
> mark as PQA

Thx for QA, Nick.
The 'trick' is needed to include the field in the submit. Could have added a
hidden input too.
I do not have a strong opinion about it. Your patch works. So fine with me.

-- 
You are receiving this mail because:
You are watching all bug changes.