[Koha-bugs] [Bug 19171] Confusing message "no items available" when placing a hold in OPAC

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to M. Tompsett from comment #5)
> Comment on attachment 74710 [details] [review]
> Bug 19171: Attempt to make "no holds possible" messages less confusing
> 
> Review of attachment 74710 [details] [review]:
> -----------------------------------------------------------------
> 
> Failed QA for the excess tag, but it would be nice to get an answer the the
> question too.
> 
> ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
> @@ +22,4 @@
> >          <div id="holds">
> >              [% IF ( message ) %]
> >                  <div id="holdmessages" class="alert">
> > +                    <p>Sorry, you cannot place holds.</strong></p>
> 
> I believe you forgot to remove the </strong> too.

True.

> 
> @@ +174,4 @@
> >                                                  <div class="alert">You have already requested this title.</div>
> >                                              [% ELSE %]
> >                                                  [% UNLESS ( bibitemloo.bib_available ) %]
> > +                                                    <div class="alert">There are no items that can be placed on hold.</div>
> 
> If you changed items to titles above, why not here?

Because this one actually talks about items - the one above only appears now
when you try to place a hold on multiple records.

-- 
You are receiving this mail because:
You are watching all bug changes.