[Koha-bugs] [Bug 20125] Add a cron script to claim late orders

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20125

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Comment on attachment 74767
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74767
Bug 20125 - Add a script to claim late orders (ordersClaim.pl)

Review of attachment 74767:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20125&attachment=74767)
-----------------------------------------------------------------

Hi Alex, 

a few small things pointed out by QA script:

 FAIL   misc/cronjobs/ordersClaim.pl
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   FAIL   pod

                 in file misc/cronjobs/ordersClaim.pl
                *** ERROR: 
                =over on line 54 without closing =back
                 at line EOF
   OK     spelling
   OK     valid


Processing additional checks

        * Commit title does not start with 'Bug XXXXX: ' - 18e290c

And some questions and notes from first review:

::: misc/cronjobs/ordersClaim.pl
@@ +18,5 @@
> +# along with Koha; if not, see <http://www.gnu.org/licenses>.
> +
> +=head1 NAME
> +
> +ordersClaim.pl - cron script that put late orders in message queue grouped by basket.

... that puts
Or maybe:
con script to automatically generate late order claims in the message queue
grouped by basket.

@@ +129,5 @@
> +    next unless @$orders;
> +
> +    my $letter = GetPreparedLetter(
> +        module => 'claimacquisition',
> +        letter_code => 'ACQCLAIM',

The letter code for claiming acquisitions can be different from the sample
provided by Koha. Koha only checks for the module and allows you to have
multiple messages (for example in different languages). Can we make this a
script option to be more flexible? Should at lest be documented.

@@ +139,5 @@
> +        },
> +        repeat => $orders,
> +    ) or next;
> +
> +    my $admin_address = C4::Context->preference('KohaAdminEmailAddress');

Maybe use the library from the basket if set first and only fall back to
KohaAdminEmailAddress?

-- 
You are receiving this mail because:
You are watching all bug changes.