[Koha-bugs] [Bug 20444] Remove C4::Members::Attributes::GetAttributes

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20444

--- Comment #9 from Josef Moravec <josef.moravec at gmail.com> ---
(In reply to M. Tompsett from comment #5)
> Comment on attachment 73083 [details] [review]
> Bug 20444: Use Koha::Patron::Attribute::Types object for getting patron
> attributes in letter.pl
> 
> Review of attachment 73083 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: tools/letter.pl
> @@ +463,4 @@
> >          }
> >      }
> >      if ($table eq 'borrowers') {
> > +        my $attribute_types = Koha::Patron::Attribute::Types->search;
> 
> This let's you loop like an array, but it isn't ordered by code as far as I
> can tell. Feel free to correct me. Does this need to be code equivalent? Or
> just similar functionally?
> 
> @@ -462,4 @@
> >          }
> >      }
> >      if ($table eq 'borrowers') {
> > -        if ( my $attributes = C4::Members::Attributes::GetAttributes() ) {
> 
> This is a sorted array of codes...

Fixed for preserving functionality

-- 
You are receiving this mail because:
You are watching all bug changes.