[Koha-bugs] [Bug 20100] A non-superlibrarian should not be able to add superlibrarian privileges

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100

--- Comment #34 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #29)
> 1. The block reads weird, I would have written:
>   IF we are going to add or remove the librarian flag
>   THEN we check if the loggeed in patron is allowed to
> 
> But not blocker.
> 
> 2. I do not think we should shorten syspref's name. Not blocker
> 
> 3. The descriptions of the 2 options are:
> - "Do not block permitted non-superlibrarians"
> - "Allow only superlibrarians"
> It is negative for "yes" and positive for "no".
> 
> Native English speakers, sounds ok for you?

Point 2 fixed in patch 5.
Points 1 and 3 are addressed in patch 6.

-- 
You are receiving this mail because:
You are watching all bug changes.