[Koha-bugs] [Bug 20660] AddReturn should use return date override for debarments

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20660

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com
             Status|Needs Signoff               |In Discussion

--- Comment #2 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to David Bourgault from comment #1)
> Created attachment 74857 [details] [review]
> Bug 20660: AddReturn uses return_date override for new debarments
> 
> This patches is a minor tweak (single line) to C4::Circulation to use the
> return_date value as $today when calculating new debarments in AddReturn.
> 
> I've also added a test in t/db_dependent/Circulation.t
> 
> TEST PLAN
> 
> 1) comment out line 1988 in Circulation.pm ("$today = $return_date if
> $return_date")
> 2) prove t/db_dependent/Circulation.t (Fail)
> 3) uncomment the line
> 4) prove t/db_dependent/Circulation.t (Pass)

It is better to split the test from the change, so that when you want to prove
the problem you just apply the test. Then if you wish to prove the solution
also apply the second patch, and have the tests pass.

Should dropbox override the return date logic being added?

-- 
You are receiving this mail because:
You are watching all bug changes.