From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 01:40:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Jul 2018 23:40:21 +0000
Subject: [Koha-bugs] [Bug 21124] Non-Public note does not appear if added to
item in MARC field
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21124
danield at brimbank.vic.gov.au changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution|--- |FIXED
--- Comment #5 from danield at brimbank.vic.gov.au ---
Hi Katrin,
Just looked in one of the MARC frameworks and noticed there was no Koha link in
Advanced Constraints for Non-public note in the Live system. In our Test
system, there is a link for the framework. I will check the other frameworks,
but this looks like the problem.
So what you're saying is if I update the link it will wipe the current notes
that are in there? I guess I better migrate the existing notes then :)
Thanks all for your help.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 08:13:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 06:13:49 +0000
Subject: [Koha-bugs] [Bug 19436] Add SRU support for authorities
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19436
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fridolin.somers at biblibre.co
| |m
--- Comment #31 from Fridolin SOMERS ---
I think we can also remove those lines in z3950servers.tt :
// enable recordtype to include field in post
$('#recordtype').prop('disabled',false);
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 09:24:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 07:24:33 +0000
Subject: [Koha-bugs] [Bug 8089] Use Koha::Cache everywhere
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fridolin.somers at biblibre.co
| |m
--- Comment #47 from Fridolin SOMERS ---
Isn't this obsolete ?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 09:26:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 07:26:03 +0000
Subject: [Koha-bugs] [Bug 19523] Koha::Cache changes not passed to all plack
workers with in-memory caching.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19523
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fridolin.somers at biblibre.co
| |m
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 09:29:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 07:29:48 +0000
Subject: [Koha-bugs] [Bug 19523] Koha::Cache changes not passed to all plack
workers with in-memory caching.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19523
--- Comment #4 from Fridolin SOMERS ---
Indeed, Memcached is recomanded with Plack.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 10:03:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 08:03:30 +0000
Subject: [Koha-bugs] [Bug 6647] Label item search should use standard
pagination routine
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6647
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|Pushed to Stable |RESOLVED
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 10:03:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 08:03:21 +0000
Subject: [Koha-bugs] [Bug 6647] Label item search should use standard
pagination routine
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6647
--- Comment #8 from Martin Renvoize ---
Reverted from 18.05.x for 18.05.03, I missed a dependency chain here.. :'(.
--
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 10:09:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 08:09:12 +0000
Subject: [Koha-bugs] [Bug 16846] Move patron related code to Koha::Patron
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846
Bug 16846 depends on bug 20287, which changed state.
Bug 20287 Summary: Move AddMember and ModMember to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 10:09:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 08:09:12 +0000
Subject: [Koha-bugs] [Bug 20226] Get rid of CATCODE_MULTI param decision in
patron perl scripts
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20226
Bug 20226 depends on bug 20287, which changed state.
Bug 20287 Summary: Move AddMember and ModMember to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 10:09:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 08:09:12 +0000
Subject: [Koha-bugs] [Bug 21068] NorwegianPatronDBEnable - Check for prior
ModMember calls that passed 'sync'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21068
Bug 21068 depends on bug 20287, which changed state.
Bug 20287 Summary: Move AddMember and ModMember to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 10:09:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 08:09:13 +0000
Subject: [Koha-bugs] [Bug 21069] Koha::Patron->generate_userid use
encourages a race condition
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21069
Bug 21069 depends on bug 20287, which changed state.
Bug 20287 Summary: Move AddMember and ModMember to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 10:09:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 08:09:13 +0000
Subject: [Koha-bugs] [Bug 21085] Can't edit patrons with housebound module
active
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21085
Bug 21085 depends on bug 20287, which changed state.
Bug 20287 Summary: Move AddMember and ModMember to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 10:09:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 08:09:13 +0000
Subject: [Koha-bugs] [Bug 21086] Wrong mock of DateTime->now in tests
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21086
Bug 21086 depends on bug 20287, which changed state.
Bug 20287 Summary: Move AddMember and ModMember to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 10:09:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 08:09:13 +0000
Subject: [Koha-bugs] [Bug 21087] Patron's password is hashed twice when the
object is saved
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21087
Bug 21087 depends on bug 20287, which changed state.
Bug 20287 Summary: Move AddMember and ModMember to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 10:09:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 08:09:11 +0000
Subject: [Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|Pushed to Master |RESOLVED
--- Comment #42 from Martin Renvoize ---
Enhancement, not backporting to 18.05.x series.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 12:26:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 10:26:30 +0000
Subject: [Koha-bugs] [Bug 20226] Get rid of CATCODE_MULTI param decision in
patron perl scripts
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20226
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
|y.org |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 12:34:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 10:34:42 +0000
Subject: [Koha-bugs] [Bug 20226] Get rid of CATCODE_MULTI param decision in
patron perl scripts
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20226
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 12:34:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 10:34:45 +0000
Subject: [Koha-bugs] [Bug 20226] Get rid of CATCODE_MULTI param decision in
patron perl scripts
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20226
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #77103|0 |1
is obsolete| |
--- Comment #3 from Josef Moravec ---
Created attachment 77359
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77359&action=edit
Bug 20226: Centralize update child code (CATCODE_MULTI)
Code and variables to deal with the update child feature are not
centralized but copied/pasted in several scripts. Which leads to issues
obsviously (bug 20805 for instance).
Moreover the strings used by the templates are also in several template
files (or .inc)
To deal with that this patch introduces the idea to create 1 .inc file
per .js file
Here we have members-menu.inc for members-menu.js
Test plan:
- Remove all your adult categories (categories.category_type='A')
- Create a patron with a child category
- Try to update to adult category
=> The entry does no longer appears! (This is a change in the behaviour)
- Create one adult category
- Update to adult category
=> There is a JS confirmation message, if you accept the patron will
be updated to the adult category
- Create (at least) another adult category
- Create another child
- Update to adult category
=> No more confirmation message but a popup to select the adult category
- Pick one
=> The patron has been updated to the adult category
Signed-off-by: Owen Leonard
Signed-off-by: Josef Moravec
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 13:17:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 11:17:32 +0000
Subject: [Koha-bugs] [Bug 21129] New ALTER IGNORE TABLE entries need
correction in updatedatabase.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21129
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |josef.moravec at gmail.com
QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
|y.org |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 13:21:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 11:21:31 +0000
Subject: [Koha-bugs] [Bug 21129] New ALTER IGNORE TABLE entries need
correction in updatedatabase.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21129
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 13:21:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 11:21:34 +0000
Subject: [Koha-bugs] [Bug 21129] New ALTER IGNORE TABLE entries need
correction in updatedatabase.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21129
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #77330|0 |1
is obsolete| |
Attachment #77331|0 |1
is obsolete| |
--- Comment #5 from Josef Moravec ---
Created attachment 77360
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77360&action=edit
Bug 21129: New ALTER IGNORE TABLE entries need correction in updatedatabase.pl
Bug 17234 made an effort to remove the ALTER IGNORE from updatedatabase.pl so
that it could work with Mysql 5.7. But new entries have since been added to
it:
Bug 12395 - 18.06.00.005
Bug 19524 - 18.06.00.006
Bug 13560 - 18.06.00.008
This is corrected using column_exists to validate the existence of the new
columns before ALTER
Signed-off-by: Jonathan Druart
Signed-off-by: Josef Moravec
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 13:21:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 11:21:38 +0000
Subject: [Koha-bugs] [Bug 21129] New ALTER IGNORE TABLE entries need
correction in updatedatabase.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21129
--- Comment #6 from Josef Moravec ---
Created attachment 77361
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77361&action=edit
Bug 21129: Fix typo created vs created_by
Signed-off-by: Josef Moravec
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 13:52:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 11:52:08 +0000
Subject: [Koha-bugs] [Bug 8089] Use Koha::Cache everywhere
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #48 from Jonathan Druart ---
Yes, see also bug 11921 and bug 16770.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 14:52:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 12:52:38 +0000
Subject: [Koha-bugs] [Bug 21136] New: Error "No property select_city for
Koha::Patron" when saving patron record
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21136
Bug ID: 21136
Summary: Error "No property select_city for Koha::Patron" when
saving patron record
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: critical
Priority: P5 - low
Component: Patrons
Assignee: jonathan.druart at bugs.koha-community.org
Reporter: oleonard at myacpl.org
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
When I edit an existing patron in master, I get an error upon saving:
No property select_city for Koha::Patron at
/usr/share/perl5/Exception/Class/Base.pm line 73
To reproduce this error you must have cities defined in Administration ->
Cities & towns.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 14:57:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 12:57:45 +0000
Subject: [Koha-bugs] [Bug 21136] Error "No property select_city for
Koha::Patron" when saving patron record
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21136
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |20287
Status|NEW |ASSIGNED
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=21085
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287
[Bug 20287] Move AddMember and ModMember to Koha::Patron
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 14:57:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 12:57:45 +0000
Subject: [Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |21136
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21136
[Bug 21136] Error "No property select_city for Koha::Patron" when saving patron
record
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 14:57:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 12:57:45 +0000
Subject: [Koha-bugs] [Bug 21085] Can't edit patrons with housebound module
active
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21085
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=21136
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 15:00:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 13:00:54 +0000
Subject: [Koha-bugs] [Bug 21136] Error "No property select_city for
Koha::Patron" when saving patron record
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21136
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 15:00:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 13:00:58 +0000
Subject: [Koha-bugs] [Bug 21136] Error "No property select_city for
Koha::Patron" when saving patron record
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21136
--- Comment #1 from Jonathan Druart ---
Created attachment 77362
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77362&action=edit
Bug 21136: Fix add/edit patron when cities are defined
Same as bug 21085.
When cities are defined, there is a select with name="select_city" added
to the DOM and its value will be passed to memberentry.pl
We must remove it from the attribute list before creating the
Koha::Patron object
No property select_city for Koha::Patron at
/usr/share/perl5/Exception/Class/Base.pm line 73
Test plan:
Define cities
Add or edit a patron, save
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 15:04:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 13:04:24 +0000
Subject: [Koha-bugs] [Bug 19291] Make breadcrumbs for OPAC search history
consistent with other patron account pages
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19291
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 15:04:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 13:04:28 +0000
Subject: [Koha-bugs] [Bug 19291] Make breadcrumbs for OPAC search history
consistent with other patron account pages
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19291
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #77312|0 |1
is obsolete| |
--- Comment #7 from Jonathan Druart ---
Created attachment 77363
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77363&action=edit
Bug 19291: Make breadcrumbs for OPAC search history consistent with other
patron account pages
This patch adds the logged-in patron's name to the search history page's
breadcrumb navigation.
To test, apply the patch and view the OPAC search history page with no
user logged in. The breadcrumbs should read:
- Home -> Search history
Log in and return to the search history page. The breadcrumbs should
read:
- Home -> Owen Leonard -> Your search history
Signed-off-by: Maryse Simard
Followed the test plan and it works.
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 15:06:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 13:06:48 +0000
Subject: [Koha-bugs] [Bug 21137] New: Remplace BORROWER_INFO and USER_INFO
with logged_in_user
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21137
Bug ID: 21137
Summary: Remplace BORROWER_INFO and USER_INFO with
logged_in_user
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: ASSIGNED
Severity: enhancement
Priority: P5 - low
Component: Templates
Assignee: jonathan.druart at bugs.koha-community.org
Reporter: jonathan.druart at bugs.koha-community.org
QA Contact: testopia at bugs.koha-community.org
Depends on: 18403
We now have a Koha::Patron object sent to the templates, logged_in_user.
It must be used everywhere patron's info are needed.
BORROWER_INFO and USER_INFO can be replaced using it.
See commit d2f2590c894efca417112795e05248dbd16636f5
Bug 18403: Send logged_in_user to template from C4::Auth
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403
[Bug 18403] Hide patron information if not part of the logged in user library
group
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 15:06:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 13:06:48 +0000
Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the
logged in user library group
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |21137
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21137
[Bug 21137] Remplace BORROWER_INFO and USER_INFO with logged_in_user
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 15:07:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 13:07:29 +0000
Subject: [Koha-bugs] [Bug 21137] Remplace BORROWER_INFO and USER_INFO with
logged_in_user
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21137
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |19291
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19291
[Bug 19291] Make breadcrumbs for OPAC search history consistent with other
patron account pages
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 15:07:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 13:07:29 +0000
Subject: [Koha-bugs] [Bug 19291] Make breadcrumbs for OPAC search history
consistent with other patron account pages
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19291
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |21137
--- Comment #8 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #6)
> With this patch we are fixing half of the inconsistency, so yes we could fix
> that on a separate bug report, if you prefer.
See bug 21137
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21137
[Bug 21137] Remplace BORROWER_INFO and USER_INFO with logged_in_user
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 15:13:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 13:13:50 +0000
Subject: [Koha-bugs] [Bug 21137] Replace BORROWER_INFO and USER_INFO with
logged_in_user
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21137
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Version|unspecified |master
Summary|Remplace BORROWER_INFO and |Replace BORROWER_INFO and
|USER_INFO with |USER_INFO with
|logged_in_user |logged_in_user
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 15:30:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 13:30:23 +0000
Subject: [Koha-bugs] [Bug 21137] Replace BORROWER_INFO and USER_INFO with
logged_in_user
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21137
--- Comment #1 from Jonathan Druart ---
Created attachment 77364
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77364&action=edit
Bug 21137: Replace USER_INFO with logged_in_user
This patch set does several things:
- it removes USER_INFO and BORROWER_INFO
These 2 variables contained logged-in patron's info. They must be
accessed from logged_in_user
- Use patron-title.inc for the breadcrumb at the OPAC, for consistencies
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 15:30:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 13:30:20 +0000
Subject: [Koha-bugs] [Bug 21137] Replace BORROWER_INFO and USER_INFO with
logged_in_user
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21137
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 15:30:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 13:30:27 +0000
Subject: [Koha-bugs] [Bug 21137] Replace BORROWER_INFO and USER_INFO with
logged_in_user
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21137
--- Comment #2 from Jonathan Druart ---
Created attachment 77365
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77365&action=edit
Bug 21137: Replace BORROWER_INFO with logged_in_user
it also removes 'category_type' and 'description' from a couple of
opac scripts, they are not needed.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 15:34:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 13:34:27 +0000
Subject: [Koha-bugs] [Bug 21136] Error "No property select_city for
Koha::Patron" when saving patron record
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21136
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
Patch complexity|--- |Trivial patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 15:34:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 13:34:30 +0000
Subject: [Koha-bugs] [Bug 21136] Error "No property select_city for
Koha::Patron" when saving patron record
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21136
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #77362|0 |1
is obsolete| |
--- Comment #2 from Owen Leonard ---
Created attachment 77366
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77366&action=edit
Bug 21136: Fix add/edit patron when cities are defined
Same as bug 21085.
When cities are defined, there is a select with name="select_city" added
to the DOM and its value will be passed to memberentry.pl
We must remove it from the attribute list before creating the
Koha::Patron object
No property select_city for Koha::Patron at
/usr/share/perl5/Exception/Class/Base.pm line 73
Test plan:
Define cities
Add or edit a patron, save
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 15:35:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 13:35:27 +0000
Subject: [Koha-bugs] [Bug 21137] Replace BORROWER_INFO and USER_INFO with
logged_in_user
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21137
--- Comment #3 from Jonathan Druart ---
There is no exhaustive test plan here, reading the patch and hitting few opac
pages should do the work.
Also try with logged-in patrons
- with a category 'organization'
- with/without title
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 15:55:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 13:55:30 +0000
Subject: [Koha-bugs] [Bug 21121] New syspref to allow hiding of private
patron data in circulation page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21121
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 15:55:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 13:55:34 +0000
Subject: [Koha-bugs] [Bug 21121] New syspref to allow hiding of private
patron data in circulation page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21121
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #77280|0 |1
is obsolete| |
--- Comment #3 from Jonathan Druart ---
Created attachment 77367
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77367&action=edit
Bug 21121: Added new system preference to control hiding of personal patron
information in the circulation page
Libraries may want to hide personal patron data from the circulation
page for privacy reasons this syspref introduces that ability for
library staff to control the display of this data themselves without
having to ask support vendors to hide it for them.
Test plan:
1. View circulation page and input a patrons barcode or name
2. Notice if the patron has a phone number, email, street address and
city set then these are displayed in the left hand side of the screen
under the patrons name. Otherwise if all/any of these fields are not
set for the patron then the text: "No stored." is
displayed.
3. Apply this patch
4. Run ./updatedatabase.pl from the Koha shell to run the atomicupdate
5. Restart memcached and plack
6. Notice a new systempreference named
'HidePersonalPatronDetailOnCirculation' has been added, which has the
default value 'Dont'
7. Without changing the default value notice the personal patron
information is still displayed on the circulation page
8. Change the value of the syspref to 'Do' and now notice the phone
number, email address, street address and city are now hidden in the
circulation page
Sponsored-By: Catalyst IT
Signed-off-by: Owen Leonard
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 15:55:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 13:55:38 +0000
Subject: [Koha-bugs] [Bug 21121] New syspref to allow hiding of private
patron data in circulation page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21121
--- Comment #4 from Jonathan Druart ---
Created attachment 77368
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77368&action=edit
Bug 21121: Add the IGNORE clause
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 16:10:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 14:10:25 +0000
Subject: [Koha-bugs] [Bug 21137] Replace BORROWER_INFO and USER_INFO with
logged_in_user
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21137
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #77364|0 |1
is obsolete| |
Attachment #77365|0 |1
is obsolete| |
--- Comment #4 from Jonathan Druart ---
Created attachment 77369
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77369&action=edit
Bug 21137: Replace USER_INFO with logged_in_user
This patch set does several things:
- it removes USER_INFO and BORROWER_INFO
These 2 variables contained logged-in patron's info. They must be
accessed from logged_in_user
- Use patron-title.inc for the breadcrumb at the OPAC, for consistencies
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 16:10:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 14:10:29 +0000
Subject: [Koha-bugs] [Bug 21137] Replace BORROWER_INFO and USER_INFO with
logged_in_user
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21137
--- Comment #5 from Jonathan Druart ---
Created attachment 77370
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77370&action=edit
Bug 21137: use logged_in_user from opac-user.pl
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 16:10:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 14:10:33 +0000
Subject: [Koha-bugs] [Bug 21137] Replace BORROWER_INFO and USER_INFO with
logged_in_user
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21137
--- Comment #6 from Jonathan Druart ---
Created attachment 77371
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77371&action=edit
Bug 21137: Replace BORROWER_INFO with logged_in_user
it also removes 'category_type' and 'description' from a couple of
opac scripts, they are not needed.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 16:22:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 14:22:48 +0000
Subject: [Koha-bugs] [Bug 20795] koha-rebuild-zebra should pass through
increased verbosity
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20795
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 16:22:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 14:22:52 +0000
Subject: [Koha-bugs] [Bug 20795] koha-rebuild-zebra should pass through
increased verbosity
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20795
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #75482|0 |1
is obsolete| |
--- Comment #4 from Jonathan Druart ---
Created attachment 77372
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77372&action=edit
Bug 20795: Pass incrreased verbosity to zebra rebuild script
To test:
1 - Run koha-rebuild-zebra with multiple '-v'
2 - Note no increased verbosity
3 - Apply patch
4 - Run the updated koha-rebuild-zebra script with multiple '-v'
5 - Note increased verbosity
Signed-off-by: Mark Tompsett
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 16:22:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 14:22:57 +0000
Subject: [Koha-bugs] [Bug 20795] koha-rebuild-zebra should pass through
increased verbosity
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20795
--- Comment #5 from Jonathan Druart ---
Created attachment 77373
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77373&action=edit
Bug 20795: Inform the user about this change, add to pod
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 16:31:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 14:31:24 +0000
Subject: [Koha-bugs] [Bug 20044] Switch single-column templates to Bootstrap
grid: Cataloging
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
--- Comment #16 from Jonathan Druart ---
https://lists.katipo.co.nz/pipermail/koha/2018-July/051113.html
[Koha] Requesting opinions on proposed change to cataloging interface
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 16:35:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 14:35:37 +0000
Subject: [Koha-bugs] [Bug 20044] Switch single-column templates to Bootstrap
grid: Cataloging
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--- Comment #17 from Jonathan Druart ---
There is something wrong with the select2:
https://screenshots.firefox.com/LinttprCI59Mq0Jn/pro.kohadev.org
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 17:05:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 15:05:38 +0000
Subject: [Koha-bugs] [Bug 21136] Error "No property select_city for
Koha::Patron" when saving patron record
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21136
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 17:05:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 15:05:43 +0000
Subject: [Koha-bugs] [Bug 21136] Error "No property select_city for
Koha::Patron" when saving patron record
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21136
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #77366|0 |1
is obsolete| |
--- Comment #3 from Katrin Fischer ---
Created attachment 77374
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77374&action=edit
Bug 21136: Fix add/edit patron when cities are defined
Same as bug 21085.
When cities are defined, there is a select with name="select_city" added
to the DOM and its value will be passed to memberentry.pl
We must remove it from the attribute list before creating the
Koha::Patron object
No property select_city for Koha::Patron at
/usr/share/perl5/Exception/Class/Base.pm line 73
Test plan:
Define cities
Add or edit a patron, save
Signed-off-by: Owen Leonard
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 17:18:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 15:18:23 +0000
Subject: [Koha-bugs] [Bug 18236] Add classes to material type icons on
intranet result lists and detail pages
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Add classes to material |Add classes to material
|type icons on result lists |type icons on intranet
|and detail pages |result lists and detail
| |pages
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 17:18:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 15:18:35 +0000
Subject: [Koha-bugs] [Bug 18236] MARC21: Add classes to material type icons
on intranet result lists and detail pages
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Add classes to material |MARC21: Add classes to
|type icons on intranet |material type icons on
|result lists and detail |intranet result lists and
|pages |detail pages
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 17:24:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 15:24:30 +0000
Subject: [Koha-bugs] [Bug 21133] Missing use C4::Accounts statement in
Koha/Patron.pm
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133
--- Comment #10 from Tom?s Cohen Arazi ---
Follow-up pushed as well, thanks Jonathan!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 17:25:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 15:25:43 +0000
Subject: [Koha-bugs] [Bug 18236] MARC21: Add classes to material type icons
on intranet result lists and detail pages
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #76149|0 |1
is obsolete| |
Attachment #76150|0 |1
is obsolete| |
--- Comment #9 from Katrin Fischer ---
Created attachment 77375
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77375&action=edit
Bug 18236: MARC21 - Add classes to material type on intranet detail and results
pages
Test plan:
1. Open a list of results
2. Use fn+f12 to inspect element
3. Without patch it should show that the image class is 'materialtype'
4. With patch there will be an additional class
-Books = mt_icon_BK
-Kit = mt_icon_MX
-Article = mt_icon_AR
-Continuous resource = mt_icon_CR
-Mixed material = mt_icon_MX
-Computer files = mt_icon_CF
-Map = mt_icon_MP
-Music = mt_icon_MU
-Sound = mt_icon_MU
-Score = mt_icon_PR
-Visual material = mt_icon_VM
OR
1. Try using the classes in css to change the style
-When viewing the details of a record, the material type img should also have
the
same changes
-Check that the material type classes in the results page is the same as
the details page
Signed-off-by: Owen Leonard
Signed-off-by: Katrin Fischer
I've squashed the patches to make chanes easier readable.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 17:27:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 15:27:28 +0000
Subject: [Koha-bugs] [Bug 21138] New: MARC21: Add classes to material type
icons on OPAC result lists and detail pages
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21138
Bug ID: 21138
Summary: MARC21: Add classes to material type icons on OPAC
result lists and detail pages
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: OPAC
Assignee: oleonard at myacpl.org
Reporter: katrin.fischer at bsz-bw.de
QA Contact: testopia at bugs.koha-community.org
Bug 18236 adds a material type class to the icons on the intranet detail and
results pages. It would be nice to have the same changes for the OPAC.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 17:27:44 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 15:27:44 +0000
Subject: [Koha-bugs] [Bug 18236] MARC21: Add classes to material type icons
on intranet result lists and detail pages
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--- Comment #10 from Katrin Fischer ---
It would be great if someone could include those changes in the OPAC as well,
I've filed bug 21138.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 18:06:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 16:06:36 +0000
Subject: [Koha-bugs] [Bug 21139] New: The floating toolbars have some issues
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139
Bug ID: 21139
Summary: The floating toolbars have some issues
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: ASSIGNED
Severity: normal
Priority: P5 - low
Component: Templates
Assignee: jonathan.druart at bugs.koha-community.org
Reporter: jonathan.druart at bugs.koha-community.org
QA Contact: testopia at bugs.koha-community.org
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 18:06:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 16:06:46 +0000
Subject: [Koha-bugs] [Bug 21139] The floating toolbars have some issues
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |21099
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21099
[Bug 21099] Floating toolbars reposition too late
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 18:06:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 16:06:46 +0000
Subject: [Koha-bugs] [Bug 21099] Floating toolbars reposition too late
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21099
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |21139
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139
[Bug 21139] The floating toolbars have some issues
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 18:14:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 16:14:30 +0000
Subject: [Koha-bugs] [Bug 21137] Replace BORROWER_INFO and USER_INFO with
logged_in_user
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21137
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Small patch
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 18:14:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 16:14:33 +0000
Subject: [Koha-bugs] [Bug 21137] Replace BORROWER_INFO and USER_INFO with
logged_in_user
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21137
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #77369|0 |1
is obsolete| |
Attachment #77370|0 |1
is obsolete| |
Attachment #77371|0 |1
is obsolete| |
--- Comment #7 from Owen Leonard ---
Created attachment 77376
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77376&action=edit
Bug 21137: Replace USER_INFO with logged_in_user
This patch set does several things:
- it removes USER_INFO and BORROWER_INFO
These 2 variables contained logged-in patron's info. They must be
accessed from logged_in_user
- Use patron-title.inc for the breadcrumb at the OPAC, for consistencies
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 18:14:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 16:14:36 +0000
Subject: [Koha-bugs] [Bug 21137] Replace BORROWER_INFO and USER_INFO with
logged_in_user
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21137
--- Comment #8 from Owen Leonard ---
Created attachment 77377
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77377&action=edit
Bug 21137: use logged_in_user from opac-user.pl
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 18:14:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 16:14:41 +0000
Subject: [Koha-bugs] [Bug 21137] Replace BORROWER_INFO and USER_INFO with
logged_in_user
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21137
--- Comment #9 from Owen Leonard ---
Created attachment 77378
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77378&action=edit
Bug 21137: Replace BORROWER_INFO with logged_in_user
it also removes 'category_type' and 'description' from a couple of
opac scripts, they are not needed.
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 18:21:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 16:21:22 +0000
Subject: [Koha-bugs] [Bug 21011] Data inconsistencies - items.holdingbranch
| items.homebranch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21011
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #4 from Katrin Fischer ---
Some help with -h would be nice, but not blocker.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 18:21:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 16:21:25 +0000
Subject: [Koha-bugs] [Bug 21139] The floating toolbars have some issues
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 18:21:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 16:21:29 +0000
Subject: [Koha-bugs] [Bug 21139] The floating toolbars have some issues
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139
--- Comment #1 from Jonathan Druart ---
Created attachment 77379
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77379&action=edit
Bug 21139: Floating toolbar - Remove dup id
We should not have twice the same id, we always use fixFloat() on an
element with an id and then duplicate this element.
The id must be changed (just in case)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 18:21:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 16:21:33 +0000
Subject: [Koha-bugs] [Bug 21139] The floating toolbars have some issues
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139
--- Comment #2 from Jonathan Druart ---
Created attachment 77380
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77380&action=edit
Bug 21139: Floating toolbars - Remove unecessary height
This patch remove some pixels under the toolbar, they were used by the
hidden element.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 18:21:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 16:21:37 +0000
Subject: [Koha-bugs] [Bug 21139] The floating toolbars have some issues
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139
--- Comment #3 from Jonathan Druart ---
Created attachment 77381
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77381&action=edit
Bug 21139: Floating toolbar - Remove horizontal scrollbar on resize
To test:
- add/edit a patron
- resize the window
=> Without this patch a horizontal scrollbar appears when resized
shorter
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 18:21:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 16:21:41 +0000
Subject: [Koha-bugs] [Bug 21139] The floating toolbars have some issues
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139
--- Comment #4 from Jonathan Druart ---
Created attachment 77382
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77382&action=edit
Bug 21139: Floating toolbar - Resize toolbar on window resize
Prior to this patch the toolbar was not resized when the window was
resized
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 18:21:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 16:21:45 +0000
Subject: [Koha-bugs] [Bug 21139] The floating toolbars have some issues
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139
--- Comment #5 from Jonathan Druart ---
Created attachment 77383
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77383&action=edit
Bug 21139: No table in toolbar
We do not need this selector, we will not have a table in the toolbar
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 18:23:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 16:23:09 +0000
Subject: [Koha-bugs] [Bug 21011] Data inconsistencies - items.holdingbranch
| items.homebranch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21011
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #76536|0 |1
is obsolete| |
--- Comment #5 from Katrin Fischer ---
Created attachment 77384
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77384&action=edit
Bug 21011: Search for items with not defined homebranch and/or holdingbranch
>From bug 5789: scripts can fail if items.homebranch and/or
items.holdingbranch is not defined
This script will help people catching these migration issues.
Test plan:
Update your items table to set some homebranch or holdingbranch to NULL
Run this script
It will display the different items with not defined values in these
fields.
Signed-off-by: Josef Moravec
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 18:23:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 16:23:14 +0000
Subject: [Koha-bugs] [Bug 21011] Data inconsistencies - items.holdingbranch
| items.homebranch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21011
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #76537|0 |1
is obsolete| |
--- Comment #6 from Katrin Fischer ---
Created attachment 77385
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77385&action=edit
Bug 21011: (follow-up) Fix pod, fix missing homebranch condition, change mode
to executable
Signed-off-by: Josef Moravec
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 18:23:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 16:23:29 +0000
Subject: [Koha-bugs] [Bug 21011] Data inconsistencies - items.holdingbranch
| items.homebranch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21011
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 18:24:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 16:24:04 +0000
Subject: [Koha-bugs] [Bug 20509] Data consistency - authority types
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20509
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #76538|0 |1
is obsolete| |
--- Comment #4 from Katrin Fischer ---
Created attachment 77386
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77386&action=edit
Bug 20509: Search for not defined authority codes
This patch adds a new check in
misc/maintenance/search_for_data_inconsistencies.pl to search for not
defined authority codes.
Test plan:
Set some auth_header.authtypecode to not defined authority codes in Koha
(UPDATE auth_header SET authtypecode="XXX" WHERE authid=42;)
Then run `misc/maintenance/search_for_data_inconsistencies.pl`
Signed-off-by: Josef Moravec
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 18:24:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 16:24:08 +0000
Subject: [Koha-bugs] [Bug 20509] Data consistency - authority types
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20509
--- Comment #5 from Katrin Fischer ---
Created attachment 77387
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77387&action=edit
Bug 20509: Add to script documentation
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 18:24:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 16:24:26 +0000
Subject: [Koha-bugs] [Bug 20509] Data consistency - authority types
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20509
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
CC| |katrin.fischer at bsz-bw.de
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 18:42:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 16:42:02 +0000
Subject: [Koha-bugs] [Bug 21011] Data inconsistencies - items.holdingbranch
| items.homebranch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21011
--- Comment #7 from Jonathan Druart ---
(In reply to Katrin Fischer from comment #4)
> Some help with -h would be nice, but not blocker.
Yes, the idea is to collect ideas first. Then it will certainly rewritten
depending on the needs we found.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 18:42:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 16:42:56 +0000
Subject: [Koha-bugs] [Bug 21011] Data inconsistencies - items.holdingbranch
| items.homebranch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21011
--- Comment #8 from Katrin Fischer ---
Idea: no itemtype set. :)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 18:46:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 16:46:00 +0000
Subject: [Koha-bugs] [Bug 19039] Results of virtual shelves (lists) not
sortable by date
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19039
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
--- Comment #6 from Owen Leonard ---
After creating a list which is sorted by default by date added, when I view it
in the OPAC the "Sort by" dropdown doesn't have "Date added" preselected.
Everything else looks good.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 18:49:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 16:49:56 +0000
Subject: [Koha-bugs] [Bug 21092] Bad template in patron card creator can
cause server issues
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21092
--- Comment #8 from Katrin Fischer ---
Thx! We haven't been able yet to narrow it down more, but it's a little scary.
So would be nice to figure out what happens there.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 19:31:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 17:31:30 +0000
Subject: [Koha-bugs] [Bug 21099] Floating toolbars reposition too late
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21099
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Small patch
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 19:31:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 17:31:34 +0000
Subject: [Koha-bugs] [Bug 21099] Floating toolbars reposition too late
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21099
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #77175|0 |1
is obsolete| |
--- Comment #3 from Katrin Fischer ---
Created attachment 77388
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77388&action=edit
Bug 21099: Reposition floating toolbars earlier
To recreate:
- Go to the advanced search form
- scrolldown to position the toolbar on top of the window
- scrollup
https://screenshots.firefox.com/NnkFg3iOXqLPxfkd/pro.kohadev.org
The toolbar should have been repositioned earlier
Test plan:
Edit a patron
- scrolldown
- scrollup
- unfold the form in the header (tab "Search patrons", link "[+]")
- scrolldown
- scrollup
Advanced search
scrolldown
scrollup
You should notice the difference with and without this patch
Signed-off-by: Pierre-Luc Lapointe
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 19:39:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 17:39:11 +0000
Subject: [Koha-bugs] [Bug 21131] Changing and restoring a WYSIWYG preference
can result in unexpected behaviour
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21131
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
Patch complexity|--- |Trivial patch
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 19:39:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 17:39:15 +0000
Subject: [Koha-bugs] [Bug 21131] Changing and restoring a WYSIWYG preference
can result in unexpected behaviour
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21131
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #77322|0 |1
is obsolete| |
--- Comment #2 from Owen Leonard ---
Created attachment 77389
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77389&action=edit
Bug 21131 - Changing and restoring a WYSIWYG preference can result in
unexpected behaviour
When using the WYSIWYG editor for system preferences, the editor only
updates the textarea element if the content is different from the
original content. This means if you change a system preference and
then change it back to the original content, the textarea will have
the 2nd last change you made.
This patch removes the TinyMCE.isDirty() check, which was responsible
for comparing the original and changed content. Every input/keydown/dragend
or TinyMCE command will cause the textarea element to be updated and
trigger the input event which causes the "modified" class to be added
to the element, so that the system preference can be saved.
__TEST PLAN__
_Before applying_
0. Change "UseWYSIWYGinSystemPreferences" to "Show"
1. Change "opaccredits" to "123a"
2. Click "Save all OPAC preferences"
3. Reload the page
4. Change "opaccredits" to "123"
5. Change "opaccredits" to "123a"
6. Click "Save all OPAC preferences"
7. Reload the page
8. Note that "opaccredits" says "123"
_Apply the patch_
_After applying_
1. Change "opaccredits" to "123a"
2. Change "opaccredits" to "123"
3. Click "Save all OPAC preferences"
4. Reload the page
5. Note that "opaccredits" says "123" (and not "123a")
6. Change "opaccredits" to "1234"
7. Click "Save all OPAC preferences"
8. Reload the page
9. Note that "opaccredits" says "1234"
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 19:49:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 17:49:34 +0000
Subject: [Koha-bugs] [Bug 20366] More information about orders linked to
subscriptions on "Acquisition details" tab
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
--- Comment #9 from Owen Leonard ---
I get an error when I try to view detail.pl:
Template process failed: undef error -
DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column 'me.created_by' in
'field list' at /home/vagrant/kohaclone/Koha/Objects.pm line 269
at /home/vagrant/kohaclone/C4/Templates.pm line 122
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 19:51:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 17:51:18 +0000
Subject: [Koha-bugs] [Bug 21131] Changing and restoring a WYSIWYG preference
can result in unexpected behaviour
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21131
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #77389|0 |1
is obsolete| |
--- Comment #3 from Katrin Fischer ---
Created attachment 77390
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77390&action=edit
Bug 21131: Remove the TinyMCE.isDirty() check that caused unexpected behaviour
When using the WYSIWYG editor for system preferences, the editor only
updates the textarea element if the content is different from the
original content. This means if you change a system preference and
then change it back to the original content, the textarea will have
the 2nd last change you made.
This patch removes the TinyMCE.isDirty() check, which was responsible
for comparing the original and changed content. Every input/keydown/dragend
or TinyMCE command will cause the textarea element to be updated and
trigger the input event which causes the "modified" class to be added
to the element, so that the system preference can be saved.
__TEST PLAN__
_Before applying_
0. Change "UseWYSIWYGinSystemPreferences" to "Show"
1. Change "opaccredits" to "123a"
2. Click "Save all OPAC preferences"
3. Reload the page
4. Change "opaccredits" to "123"
5. Change "opaccredits" to "123a"
6. Click "Save all OPAC preferences"
7. Reload the page
8. Note that "opaccredits" says "123"
_Apply the patch_
_After applying_
1. Change "opaccredits" to "123a"
2. Change "opaccredits" to "123"
3. Click "Save all OPAC preferences"
4. Reload the page
5. Note that "opaccredits" says "123" (and not "123a")
6. Change "opaccredits" to "1234"
7. Click "Save all OPAC preferences"
8. Reload the page
9. Note that "opaccredits" says "1234"
Signed-off-by: Owen Leonard
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 19:51:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 17:51:49 +0000
Subject: [Koha-bugs] [Bug 21131] Changing and restoring a WYSIWYG preference
can result in unexpected behaviour
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21131
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
CC| |katrin.fischer at bsz-bw.de
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 19:52:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 17:52:31 +0000
Subject: [Koha-bugs] [Bug 21131] Changing and restoring a WYSIWYG preference
can result in unexpected behaviour
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21131
--- Comment #4 from Katrin Fischer ---
Hi David, we standardized the commit messages a bit more:
https://wiki.koha-community.org/wiki/Commit_messages
- Start with Bug XXXX:
- Describe the fix in the subject, not the problem :)
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 19:53:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 17:53:41 +0000
Subject: [Koha-bugs] [Bug 21140] New: Mechanism added to import
functionality & cataloging re: MARC21 fields 035 & 001, frameworks
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21140
Bug ID: 21140
Summary: Mechanism added to import functionality & cataloging
re: MARC21 fields 035 & 001, frameworks
Change sponsored?: ---
Product: Koha
Version: 17.11
Hardware: PC
OS: Windows
Status: NEW
Severity: new feature
Priority: P5 - low
Component: Cataloging
Assignee: koha-bugs at lists.koha-community.org
Reporter: emjhet at pa.net
QA Contact: testopia at bugs.koha-community.org
CC: m.de.rooy at rijksmuseum.nl
Would like to see the following enhancements to import functionality:
1. When importing a bibliographic record into Koha, the imported 001 would
automatically move to the 035$a.
Would like to see the following enhancements to cataloging:
1. Have the option to have the 999$c copied into the 001 when the bibliographic
record is initially saved.
2. The ability to select which framework we wish to have as the default
framework.
This would permit us to better follow the cataloging rules and practices
governed by AACR2r, RDA, LC, and local practice.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 20:01:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 18:01:09 +0000
Subject: [Koha-bugs] [Bug 20044] Switch single-column templates to Bootstrap
grid: Cataloging
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044
--- Comment #18 from Owen Leonard ---
(In reply to Jonathan Druart from comment #17)
> There is something wrong with the select2:
> https://screenshots.firefox.com/LinttprCI59Mq0Jn/pro.kohadev.org
I do not see this problem with Firefox on Windows 10.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 20:35:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 18:35:50 +0000
Subject: [Koha-bugs] [Bug 21139] The floating toolbars have some issues
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Small patch
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 20:35:53 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 18:35:53 +0000
Subject: [Koha-bugs] [Bug 21139] The floating toolbars have some issues
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #77379|0 |1
is obsolete| |
Attachment #77380|0 |1
is obsolete| |
Attachment #77381|0 |1
is obsolete| |
Attachment #77382|0 |1
is obsolete| |
Attachment #77383|0 |1
is obsolete| |
--- Comment #6 from Owen Leonard ---
Created attachment 77391
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77391&action=edit
Bug 21139: Floating toolbar - Remove dup id
We should not have twice the same id, we always use fixFloat() on an
element with an id and then duplicate this element.
The id must be changed (just in case)
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 20:36:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 18:36:00 +0000
Subject: [Koha-bugs] [Bug 21139] The floating toolbars have some issues
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139
--- Comment #8 from Owen Leonard ---
Created attachment 77393
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77393&action=edit
Bug 21139: Floating toolbar - Remove horizontal scrollbar on resize
To test:
- add/edit a patron
- resize the window
=> Without this patch a horizontal scrollbar appears when resized
shorter
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 20:36:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 18:36:04 +0000
Subject: [Koha-bugs] [Bug 21139] The floating toolbars have some issues
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139
--- Comment #9 from Owen Leonard ---
Created attachment 77394
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77394&action=edit
Bug 21139: Floating toolbar - Resize toolbar on window resize
Prior to this patch the toolbar was not resized when the window was
resized
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 20:36:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 18:36:07 +0000
Subject: [Koha-bugs] [Bug 21139] The floating toolbars have some issues
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139
--- Comment #10 from Owen Leonard ---
Created attachment 77395
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77395&action=edit
Bug 21139: No table in toolbar
We do not need this selector, we will not have a table in the toolbar
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 20:35:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 18:35:57 +0000
Subject: [Koha-bugs] [Bug 21139] The floating toolbars have some issues
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139
--- Comment #7 from Owen Leonard ---
Created attachment 77392
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77392&action=edit
Bug 21139: Floating toolbars - Remove unecessary height
This patch remove some pixels under the toolbar, they were used by the
hidden element.
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 20:38:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 18:38:37 +0000
Subject: [Koha-bugs] [Bug 20366] More information about orders linked to
subscriptions on "Acquisition details" tab
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366
--- Comment #10 from Jonathan Druart ---
I do not recreate that, could you confirm you do not have this issue on master?
Or without patches from this bug, i.e. with patches from bug 20365?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 20:54:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 18:54:42 +0000
Subject: [Koha-bugs] [Bug 20044] Switch single-column templates to Bootstrap
grid: Cataloging
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044
--- Comment #19 from Jonathan Druart ---
I do on debian, both Firefox 61.0.1 (64-bit) and Chromium Version 67.0.3396.87
It comes from select2.inc:
8 width: function() {
9 var width = this.element.outerWidth();
After this line width is always = 0
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 20:58:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 18:58:48 +0000
Subject: [Koha-bugs] [Bug 20366] More information about orders linked to
subscriptions on "Acquisition details" tab
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366
--- Comment #11 from Owen Leonard ---
(In reply to Jonathan Druart from comment #10)
> Or without patches from this bug, i.e. with patches from bug 20365?
I have this problem on master, only happens after applying this patch set (not
with the patch dependencies).
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 21:18:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 19:18:13 +0000
Subject: [Koha-bugs] [Bug 21141] New: Batch item modification throws error
500 when an itemnumber is invalid
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21141
Bug ID: 21141
Summary: Batch item modification throws error 500 when an
itemnumber is invalid
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Tools
Assignee: koha-bugs at lists.koha-community.org
Reporter: victor.grousset at biblibre.com
QA Contact: testopia at bugs.koha-community.org
Error example:
Can't call method "title" on an undefined value at
/home/koha/src/tools/batchMod.pl line 591, <$fh> line 6.
== Test plan ==
1. Create a file named valid-itemnumbers.csv with valid itemnumbers
With the following structure:
5456
5495
6546
2. Go to Staff ? Tools ? Batch item modification
3. Tick "Item number file"
4. Upload the file (click "continue")
5. See that it works
6. Create a file named invalid-itemnumbers.csv with invalid itemnumbers
7. Retry
8. See that it fails
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 21:18:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 19:18:19 +0000
Subject: [Koha-bugs] [Bug 20044] Switch single-column templates to Bootstrap
grid: Cataloging
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044
--- Comment #20 from Jonathan Druart ---
Created attachment 77396
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77396&action=edit
Bug 20044: Fix input_marceditor selectors
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 21:19:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 19:19:02 +0000
Subject: [Koha-bugs] [Bug 21141] Batch item modification throws error 500
when an itemnumber is invalid
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21141
--- Comment #1 from Victor Grousset/tuxayo ---
Actually just one invalid itemnumber is enough.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 21:21:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 19:21:04 +0000
Subject: [Koha-bugs] [Bug 21141] Batch item modification throws error 500
when an itemnumber is invalid
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21141
--- Comment #2 from Victor Grousset/tuxayo ---
I'm not sure to work on this. Anyone can feel free to take it.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 21:22:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 19:22:27 +0000
Subject: [Koha-bugs] [Bug 21141] Batch item modification throws error 500
when an itemnumber is invalid
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21141
--- Comment #3 from Victor Grousset/tuxayo ---
Details:
Error is here:
https://gitlab.com/koha-community/Koha/blob/ce96080f3005be5a63c9f2cab8d4b6c81e9b5b27/tools/batchMod.pl#L580
Because $biblio is undef
Because $itemdata is undef (or empty I forgot)
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 21:23:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 19:23:52 +0000
Subject: [Koha-bugs] [Bug 21141] Batch item modification throws error 500
when an itemnumber is invalid
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21141
--- Comment #4 from Victor Grousset/tuxayo ---
Note that when uploading a barcode file, there is an error handling logic which
displays the invalid numbers. So the fix could be built from there.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 21:27:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 19:27:42 +0000
Subject: [Koha-bugs] [Bug 21137] Replace BORROWER_INFO and USER_INFO with
logged_in_user
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21137
--- Comment #10 from Katrin Fischer ---
Created attachment 77397
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77397&action=edit
Bug 19291: Make breadcrumbs for OPAC search history consistent with other
patron account pages
This patch adds the logged-in patron's name to the search history page's
breadcrumb navigation.
To test, apply the patch and view the OPAC search history page with no
user logged in. The breadcrumbs should read:
- Home -> Search history
Log in and return to the search history page. The breadcrumbs should
read:
- Home -> Owen Leonard -> Your search history
Signed-off-by: Maryse Simard
Followed the test plan and it works.
Signed-off-by: Jonathan Druart
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 21:27:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 19:27:47 +0000
Subject: [Koha-bugs] [Bug 21137] Replace BORROWER_INFO and USER_INFO with
logged_in_user
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21137
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #77376|0 |1
is obsolete| |
--- Comment #11 from Katrin Fischer ---
Created attachment 77398
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77398&action=edit
Bug 21137: Replace USER_INFO with logged_in_user
This patch set does several things:
- it removes USER_INFO and BORROWER_INFO
These 2 variables contained logged-in patron's info. They must be
accessed from logged_in_user
- Use patron-title.inc for the breadcrumb at the OPAC, for consistencies
Signed-off-by: Owen Leonard
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 21:27:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 19:27:51 +0000
Subject: [Koha-bugs] [Bug 21137] Replace BORROWER_INFO and USER_INFO with
logged_in_user
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21137
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #77377|0 |1
is obsolete| |
--- Comment #12 from Katrin Fischer ---
Created attachment 77399
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77399&action=edit
Bug 21137: use logged_in_user from opac-user.pl
Signed-off-by: Owen Leonard
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 21:27:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 19:27:56 +0000
Subject: [Koha-bugs] [Bug 21137] Replace BORROWER_INFO and USER_INFO with
logged_in_user
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21137
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #77378|0 |1
is obsolete| |
--- Comment #13 from Katrin Fischer ---
Created attachment 77400
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77400&action=edit
Bug 21137: Replace BORROWER_INFO with logged_in_user
it also removes 'category_type' and 'description' from a couple of
opac scripts, they are not needed.
Signed-off-by: Owen Leonard
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 21:28:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 19:28:18 +0000
Subject: [Koha-bugs] [Bug 21137] Replace BORROWER_INFO and USER_INFO with
logged_in_user
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21137
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
Status|Signed Off |Passed QA
--- Comment #14 from Katrin Fischer ---
Smuggled in a small follow-up - same pattern as patch on bug 19291.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 21:29:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 19:29:12 +0000
Subject: [Koha-bugs] [Bug 21137] Replace BORROWER_INFO and USER_INFO with
logged_in_user
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21137
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #77399|0 |1
is obsolete| |
--- Comment #16 from Katrin Fischer ---
Created attachment 77402
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77402&action=edit
Bug 21137: use logged_in_user from opac-user.pl
Signed-off-by: Owen Leonard
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 21:29:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 19:29:18 +0000
Subject: [Koha-bugs] [Bug 21137] Replace BORROWER_INFO and USER_INFO with
logged_in_user
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21137
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #77400|0 |1
is obsolete| |
--- Comment #17 from Katrin Fischer ---
Created attachment 77403
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77403&action=edit
Bug 21137: Replace BORROWER_INFO with logged_in_user
it also removes 'category_type' and 'description' from a couple of
opac scripts, they are not needed.
Signed-off-by: Owen Leonard
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 21:29:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 19:29:20 +0000
Subject: [Koha-bugs] [Bug 21137] Replace BORROWER_INFO and USER_INFO with
logged_in_user
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21137
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #77397|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 21:29:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 19:29:24 +0000
Subject: [Koha-bugs] [Bug 21137] Replace BORROWER_INFO and USER_INFO with
logged_in_user
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21137
--- Comment #18 from Katrin Fischer ---
Created attachment 77404
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77404&action=edit
Bug 21137: Standardize breadcrumbs for tags page
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 21:29:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 19:29:07 +0000
Subject: [Koha-bugs] [Bug 21137] Replace BORROWER_INFO and USER_INFO with
logged_in_user
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21137
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #77398|0 |1
is obsolete| |
--- Comment #15 from Katrin Fischer ---
Created attachment 77401
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77401&action=edit
Bug 21137: Replace USER_INFO with logged_in_user
This patch set does several things:
- it removes USER_INFO and BORROWER_INFO
These 2 variables contained logged-in patron's info. They must be
accessed from logged_in_user
- Use patron-title.inc for the breadcrumb at the OPAC, for consistencies
Signed-off-by: Owen Leonard
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 21:30:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 19:30:05 +0000
Subject: [Koha-bugs] [Bug 19291] Make breadcrumbs for OPAC search history
consistent with other patron account pages
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19291
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #77363|0 |1
is obsolete| |
--- Comment #9 from Katrin Fischer ---
Created attachment 77405
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77405&action=edit
Bug 19291: Make breadcrumbs for OPAC search history consistent with other
patron account pages
This patch adds the logged-in patron's name to the search history page's
breadcrumb navigation.
To test, apply the patch and view the OPAC search history page with no
user logged in. The breadcrumbs should read:
- Home -> Search history
Log in and return to the search history page. The breadcrumbs should
read:
- Home -> Owen Leonard -> Your search history
Signed-off-by: Maryse Simard
Followed the test plan and it works.
Signed-off-by: Jonathan Druart
Signed-off-by: Katrin Fischer
https://bugs.koha-community.org/show_bug.cgi?id=21137
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 21:52:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 19:52:59 +0000
Subject: [Koha-bugs] [Bug 21142] New: Batch item modification tool is
corrupted by BOM (byte order mark) in the uploaded file
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21142
Bug ID: 21142
Summary: Batch item modification tool is corrupted by BOM (byte
order mark) in the uploaded file
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Tools
Assignee: koha-bugs at lists.koha-community.org
Reporter: victor.grousset at biblibre.com
QA Contact: testopia at bugs.koha-community.org
It also affects "Item number files" which triggers bug 21141
But it's easier to test with barcodes. And the fix should be the same.
== Test plan ==
1. Go to Staff ? Tools ? Batch item modification
2. Upload the file from the attachments (see next comments) named
numbers-without-BOM.csv
3. See that it complains about non existing barcodes but the codes look ok
4. Upload the file from the attachments named numbers-with-BOM.csv
5. See that the first line is corrupted.
Something like "???3131545845784555"
If you don't know how to check that my test files are correct.
On a Unix-like system do:
file numbers-with-BOM.csv
file numbers-without-BOM.csv
less numbers-with-BOM.csv
less numbers-without-BOM.csv
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 21:53:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 19:53:02 +0000
Subject: [Koha-bugs] [Bug 7547] Printing a sorted cart
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
--- Comment #17 from Jonathan Druart ---
Since these patches the "Column visibility" button is displayed at the OPAC:
https://screenshots.firefox.com/OEOzq6a0aEozv8rU/catalogue.kohadev.org
It should not.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 21:53:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 19:53:13 +0000
Subject: [Koha-bugs] [Bug 21142] Batch item modification tool is corrupted
by BOM (byte order mark) in the uploaded file
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21142
Victor Grousset/tuxayo changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=21141
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 21:53:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 19:53:13 +0000
Subject: [Koha-bugs] [Bug 21141] Batch item modification throws error 500
when an itemnumber is invalid
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21141
Victor Grousset/tuxayo changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=21142
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 21:53:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 19:53:56 +0000
Subject: [Koha-bugs] [Bug 21142] Batch item modification tool is corrupted
by BOM (byte order mark) in the uploaded file
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21142
--- Comment #1 from Victor Grousset/tuxayo ---
Created attachment 77406
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77406&action=edit
Numbers without BOM
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 21:55:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 19:55:49 +0000
Subject: [Koha-bugs] [Bug 21142] Batch item modification tool is corrupted
by BOM (byte order mark) in the uploaded file
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21142
--- Comment #2 from Victor Grousset/tuxayo ---
Created attachment 77407
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77407&action=edit
Numbers with BOM
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 21:56:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 19:56:56 +0000
Subject: [Koha-bugs] [Bug 21142] Batch item modification tool is corrupted
by BOM (byte order mark) in the uploaded file
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21142
--- Comment #3 from Victor Grousset/tuxayo ---
I'm not sure to work on this. Anyone can feel free to take it.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 22:13:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 20:13:45 +0000
Subject: [Koha-bugs] [Bug 21141] Batch item modification tool throws error
500 when an itemnumber is invalid
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21141
Victor Grousset/tuxayo changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Batch item modification |Batch item modification
|throws error 500 when an |tool throws error 500 when
|itemnumber is invalid |an itemnumber is invalid
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 22:20:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 20:20:54 +0000
Subject: [Koha-bugs] [Bug 16357] Plack error logs are not time stamped
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357
--- Comment #19 from Barton Chittenden ---
Mason,
I'm really interested in having this, and I'd be happy to test and sign off if
you can rebase.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 22:52:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 20:52:40 +0000
Subject: [Koha-bugs] [Bug 14666] adds fixed_fines for overdues
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14666
Victor Grousset/tuxayo changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|In Discussion |Needs Signoff
--- Comment #12 from Victor Grousset/tuxayo ---
There doesn't seems to be any pending points right?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 22:56:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 20:56:26 +0000
Subject: [Koha-bugs] [Bug 14666] adds fixed_fines for overdues
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14666
--- Comment #13 from Victor Grousset/tuxayo ---
Wait, maybe comment 4 is still valid? Or should we move on independently of bug
12769 that might be to wide to manage to make it through? (and which is also in
discussion)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 22:58:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 20:58:56 +0000
Subject: [Koha-bugs] [Bug 14666] adds fixed_fines for overdues
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14666
--- Comment #14 from Victor Grousset/tuxayo ---
> The bug title is not very descrpitive, maybe fix in order to lure testers in?
"Add fees when overdue notices triggers" ? I'm not sure to understand well
enough to be sure if that's the aim.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 00:02:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 22:02:09 +0000
Subject: [Koha-bugs] [Bug 21139] The floating toolbars have some issues
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #77391|0 |1
is obsolete| |
--- Comment #11 from Katrin Fischer ---
Created attachment 77408
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77408&action=edit
Bug 21139: Floating toolbar - Remove dup id
We should not have twice the same id, we always use fixFloat() on an
element with an id and then duplicate this element.
The id must be changed (just in case)
Signed-off-by: Owen Leonard
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 00:02:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 22:02:14 +0000
Subject: [Koha-bugs] [Bug 21139] The floating toolbars have some issues
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #77392|0 |1
is obsolete| |
--- Comment #12 from Katrin Fischer ---
Created attachment 77409
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77409&action=edit
Bug 21139: Floating toolbars - Remove unecessary height
This patch remove some pixels under the toolbar, they were used by the
hidden element.
Signed-off-by: Owen Leonard
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 00:02:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 22:02:18 +0000
Subject: [Koha-bugs] [Bug 21139] The floating toolbars have some issues
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #77393|0 |1
is obsolete| |
--- Comment #13 from Katrin Fischer ---
Created attachment 77410
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77410&action=edit
Bug 21139: Floating toolbar - Remove horizontal scrollbar on resize
To test:
- add/edit a patron
- resize the window
=> Without this patch a horizontal scrollbar appears when resized
shorter
Signed-off-by: Owen Leonard
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 00:02:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 22:02:23 +0000
Subject: [Koha-bugs] [Bug 21139] The floating toolbars have some issues
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #77394|0 |1
is obsolete| |
--- Comment #14 from Katrin Fischer ---
Created attachment 77411
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77411&action=edit
Bug 21139: Floating toolbar - Resize toolbar on window resize
Prior to this patch the toolbar was not resized when the window was
resized
Signed-off-by: Owen Leonard
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 00:02:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 22:02:27 +0000
Subject: [Koha-bugs] [Bug 21139] The floating toolbars have some issues
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #77395|0 |1
is obsolete| |
--- Comment #15 from Katrin Fischer ---
Created attachment 77412
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77412&action=edit
Bug 21139: No table in toolbar
We do not need this selector, we will not have a table in the toolbar
Signed-off-by: Owen Leonard
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 00:06:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 22:06:03 +0000
Subject: [Koha-bugs] [Bug 21090] Description of itemtype group doesn't show
when there is an itemtype with the same code
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21090
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Version|master |17.11
--- Comment #4 from Katrin Fischer ---
I can't reproduce the issue on master. So far only confirmed for 17.11.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 00:07:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 22:07:17 +0000
Subject: [Koha-bugs] [Bug 21088] Load the correct biblio or item-level link
from tracklinks.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21088
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |DUPLICATE
Status|NEW |RESOLVED
--- Comment #2 from Katrin Fischer ---
*** This bug has been marked as a duplicate of bug 21018 ***
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 00:07:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 22:07:17 +0000
Subject: [Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is
enabled
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |alexbuckley at catalyst.net.nz
--- Comment #10 from Katrin Fischer ---
*** Bug 21088 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 00:13:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 22:13:18 +0000
Subject: [Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is
enabled
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 00:13:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 22:13:24 +0000
Subject: [Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is
enabled
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #76601|0 |1
is obsolete| |
--- Comment #11 from Katrin Fischer ---
Created attachment 77413
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77413&action=edit
Bug 21018: Fix TrackClicks for 952$u
Caused by
commit 51b6cf2aafbfb45b9fcb072403b986fe3c2add53
Bug 19847: Track links within the records and 404 for others
We should also accept uri stored in items.uri (952$u)
Test plan:
- Turn on TrackClicks
- Defined uri for some items
- At the OPAC click on the link (from opac-detail.pl)
=> Without this patch you will get 404 (redirected from tracklinks.pl)
=> With this patch applied you will be redirected correctly and the
linktracker will be filled correctly
Signed-off-by: Katrin Fischer
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 00:13:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 22:13:28 +0000
Subject: [Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is
enabled
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #76863|0 |1
is obsolete| |
--- Comment #12 from Katrin Fischer ---
Created attachment 77414
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77414&action=edit
Bug 21018: Allow uris defined in the item
We need to search for uri defined for the itemnumber we passed in
parameter.
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 00:14:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 22:14:21 +0000
Subject: [Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is
enabled
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018
--- Comment #13 from Katrin Fischer ---
With both patches it works for me as well. I have the 404 for before applying
the patch and correct redirects after.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 00:15:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 22:15:23 +0000
Subject: [Koha-bugs] [Bug 20765] Search for items by acqdate does not work
in label batch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20765
--- Comment #5 from Katrin Fischer ---
Hi Frido, using kohadevbox for testing:
Zebra version: Zebra 2.0.59 (C) 1994-2014, Index Data Zebra is free software,
covered by the GNU General Public License, and you are welcome to change it
and/or distribute copies of it under certain conditions. SHA1 ID:
c00bfddbf0f3608340d61298acc61dafb167f9b2 Using ICU
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 00:21:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 22:21:08 +0000
Subject: [Koha-bugs] [Bug 21096] Garbled username on intranet login page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21096
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Garbled username on |Garbled username on
|intranet login page. |intranet login page
CC| |katrin.fischer at bsz-bw.de
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 00:26:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 22:26:40 +0000
Subject: [Koha-bugs] [Bug 21096] Garbled username on intranet login page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21096
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 00:26:44 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2018 22:26:44 +0000
Subject: [Koha-bugs] [Bug 21096] Garbled username on intranet login page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21096
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #77271|0 |1
is obsolete| |
--- Comment #10 from Katrin Fischer