[Koha-bugs] [Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159

--- Comment #1 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Created attachment 77487
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77487&action=edit
Bug 21159 - Implementing 2 sysprefs to enable blanking location

This patch introduces two new system preferences:
BlankingShelvingLocationOnIssue and BlankingShelvingLocationOnReturn. By
default both are off.

If BlankingShelvingLocationOnIssue is enabled then when an item is issued it's
shelving location 952$c field will be set to '' in
C4::Items->BlankShelvingLocation()

If BlankingShelvingLocationOnReturn is enabled then when an item is returned
it's shelving location field will be set to '' in
C4::Items->BlankShelvingLocation().

t/db_dependent/Circulation/issue.t contains tests for
BlankShelvingLocationOnIssue

t/db_dependen/Circulation/Returns.t contains tests for
BlankShelvingLocationOnReturn

Test plan:
1. Create a new biblio and associated item and set the value of the shelving
location for the item to 'CART'
2. Checkout the item to a user and notice that the status does not change
3. Apply patch, and run ./updatedatabase.pl inside the koha shell
4. Now return the checked out item (when you updated the database you added two
new sysprefs: BlankShelvingLocationOnIssue and BlankShelvingLocationOnReturn
both of which are off by default)
5. Notice the shelving location has not changed, showing with the
BlankShelvingLocationOnReturn syspref not enabled the shelving location is not
changed upon return
6. Check the item out again and notice the shelving location is not changed,
showing that when the BlankShelvingLocationOnIssue is not enabled the shelving
location is not changed upon issue.
7. Enable both aforementioned sysprefs in the Administration->Global system
preferences->Circulation interface
8. Return the item and notice the Shelving location has changed from 'Cart' to
no value, showing when the BlankShelvingLocationOnReturn syspref is enabled it
blanks the shelving location value on the return of the item
9. Edit the item changing the shelving location back to 'Shelving
Trolley'(CART)
10. Check out the item and notice the shelving location is changed to no value,
showing when the BlankShelvingLocationOnIssue syspref is enabled it blanks the
shelving location on the issue of an item.
11. Run t/db_dependent/Circulation/Returns.t
12. Run t/db_dependent/Circulation/issue.t

Sponsored-By: Toi Ohomai Institute of Technology, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.