[Koha-bugs] [Bug 21160] New: C4::Members loads and calls Koha::Schema directly

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21160

            Bug ID: 21160
           Summary: C4::Members loads and calls Koha::Schema directly
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: dcook at prosentient.com.au
        QA Contact: testopia at bugs.koha-community.org

I just noticed that C4::Members runs "use Koha::Schema" then calls
Koha::Schema->resultset(‘Borrower’) in get_cardnumber_length(). 

Surely that should be calling Koha::Database->schema() and using
$schema->resultset(‘Borrower’)? 

It’s the only place this happens in the entire codebase (introduced by
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15690 and then moved
by a later commit), so I’m thinking it’s a bug. 

I don’t know that it would have a big impact on anything, but I figure it's
worth raising an issue for it anyway.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.