[Koha-bugs] [Bug 21184] C4::Items - Remove GetBarcodeFromItemnumber

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Aug 8 20:56:29 CEST 2018


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21184

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 77589
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77589&action=edit
Bug 21184: Replace C4::Items::GetBarcodeFromItemnumber calls

Those calls to C4::Items::GetBarcodeFromItemnumber can be replaced with
    my $barcode = Koha::Items->find($itemnumber)->barcode;
But if we are not sure that the item exists, we should test the return
of ->find before ->barcode

Test plan:
- Edit an item
- Check an item in

- Test SIP - I do not really know how to trigger that code, apparently
misc/sip_cli_emulator.pl does not deal with holds. Any ideas?

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list