[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Aug 9 13:51:05 CEST 2018


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #79 from Julian Maurice <julian.maurice at biblibre.com> ---
There are a few problems:
- 'use C4::Acquisition' is missing in acqui/spent.pl
- acqui/order.pl uses aqorders.ecost, which for me is already rounded in the
database ('9.85'), so the amount doesn't change when I change the syspref value
(it's like syspref is always "Round")
- same for reports/orders_by_fund.pl
- In admin/aqbudgets.pl, the amount doesn't change when I change the syspref
value (it's like syspref is always "Don't round")
- The result of get_rounded_price is often used in multiplication, but this is
wrong because get_rounded_price use Koha::Number::Format and this can return
strings that are not valid numbers (ex: "1,234.000")

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list