[Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha namespace

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
First QA comment.. and it's possibly a little mean..

You've introduced three 'filter_by_' methods: Awesome++.

However, there's an inconsistency with their chainability.. I personally feel
such a method should always allow chaining and as such would request, although
currently, you don't use them within a chain, that `filter_by_attribute_type`
and `filter_by_attribute_value` are altered such that they act upon self rather
than instantiating a new object to pass as the return.

-- 
You are receiving this mail because:
You are watching all bug changes.