[Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha namespace

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Aug 9 17:34:27 CEST 2018


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Failed QA

--- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Tomás Cohen Arazi from comment #6)
> I don't think we can break GetPatronInfo (ILS-DI) like this. We should keep
> the current behaviour and propose a behaviour change on a separate bug.

This:

my $attrs = $patron->extended_attributes->search({ opac_display => 1
})->unblessed;

should be:

my $attrs = grep { $_->type->opac_display } @{
$patron->extended_attributes->search };
my @attrs_unblessed = map { $_->unblessed } @{ $attrs };

Highlighted by:
k$ prove t/db_dependent/ILSDI_Services.t
t/db_dependent/ILSDI_Services.t .. 1/4 DBD::mysql::st execute failed: Unknown
column 'opac_display' in 'where clause'...

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list