[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #66 from Charles Farmer <charles.farmer at inlibro.com> ---
New patch to fix, in part, some problems raised by QA.

> Why only changes to the ...style-us and not the other templates?

If I look at it chronologically, this patch was first submitted at a time when
no {de,fr} templates existed. Commits for these templates came in 2015 and
2017, and I couldn't say when they were added to the master. It's no excuse for
not reworking the patch, if that's what QA needs, but at least there's a
rationale: it was rebased over and over without extending what had been done.

> What has this to do with making it possible for adults to be guarantors? ;)

That looks like a prime candidate for an optional patch, I concede. But some of
the 'extra' developments in this patch were naturally asked by our clients when
we offered linking adults to adults. I do think there are merits to keeping
these functionalities together (though perhaps not as far as keeping the
example you quoted).

> If we set it on the patron category, why check here for I and A?

Indeed, it's information easily retrievable from the $patron object already
sent to the template. Worst of all, it's not even used by any template linked
to moremember.pl :/

I feel like that echoes my previous comment about it being an old cookie: it
has been rebased many times to quickly offer something to test, but at the cost
of not being rewritten everytime to leverage new
functions/variables/developments.

-- 
You are receiving this mail because:
You are watching all bug changes.