[Koha-bugs] [Bug 14711] We do no longer need bibitems in AddReserve
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Thu Aug 16 20:36:06 CEST 2018
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14711
Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #42198|0 |1
is obsolete| |
--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 77940
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77940&action=edit
Bug 14711: Change prototype for AddReserve - pass a hashref
The number of parameters of AddReserve makes it hard to read and
maintain.
This patch replace it with a hashref, which will make the calls more
readable.
Moreover the bibitems has been removed as it was not used by the
subroutine.
Test plan:
- Make sure the tests pass
- Read the diff and search for typos
- Place a hold on few items
Note for QA: reservation_date and expiration_date do not match the DB column's
names,
should we?
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list