[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639

--- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Some notes from reading through the bug and code review:

1) Leftover warn in finishreceive.pl
+$replacementprice = Koha::Number::Price->new( $replacementprice )->unformat();
+warn "Replacement $replacementprice";

2) Database update
I also wonder if we should prefill replacementprice from rrp. We could argue
that not all libraries will want it to be set to rrp by default, especially as
it would change the behaviour for pending orders. 

3) Notes for for the release notes would be great. Nick?

4) Question: Why not allow editing of retail price later on? In case of a typo
you'd have to reopen the basket and that will mess with the order dates and
such... wouldn't it be easier to leave it editable?

I can remove the warn in a follow-up, still have to finish testing of the
behaviour and calculations.

-- 
You are receiving this mail because:
You are watching all bug changes.