[Koha-bugs] [Bug 19799] Changing language on OPAC redirects back to homepage

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19799

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #11 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
The right way to make things work with our codebase is to uncomment the
following line in both apache-shared-intranet-plack.conf and
apache-shared-opac-plack.conf.

# RequestHeader set X-FORWARDED-PROTO "https"

This header would be used by Plack::Middleware::ReverseProxy to make
$cgi->https work correctly [1]

The problem with that is we didn't manage to automate it for non-tech users.
That's an area we could spend time on!

The approach I aimed for having time to implement, was to split like this:

OPACBaseURL => OPACProto (http/https/gopher) + OPACDomainName + OPACBasePath
(/cgi-bin/koha, preparing the ground for removing the requirement to use that
path). The problem with this is that we of course allow different domains to be
used (a feature).

If we were to add code that workarounds the issue on the codebase, I think we
should better add it as a Plack middleware as we did in
Koha::Middleware::SetEnv.

[1]
https://github.com/plack/Plack/wiki/How-to-detect-reverse-proxy-and-SSL-frontend

-- 
You are receiving this mail because:
You are watching all bug changes.