[Koha-bugs] [Bug 21206] C4::Items - Remove GetItem

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206

--- Comment #11 from Josef Moravec <josef.moravec at gmail.com> ---
Comment on attachment 78080
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78080
Bug 21206: Replace C4::Items::GetItem

Review of attachment 78080:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=21206&attachment=78080)
-----------------------------------------------------------------

::: C4/ILSDI/Services.pm
@@ +614,5 @@
>      if ( $renewal[0] ) { AddRenewal( $borrowernumber, $itemnumber ); }
>  
> +    return unless $item; # FIXME should be handled
> +
> +    my $issue = $item->checkout;

I see still little problem here: 
If item exists and is not checked out -> boom
The check and return on item is done on line 610 here, so here should be
"return unless $issue;"

-- 
You are receiving this mail because:
You are watching all bug changes.