[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #269 from Alex Arnaud <alex.arnaud at biblibre.com> ---
(In reply to Jonathan Druart from comment #253)
> 1. Unit tests:
> [kohadev-koha at kohadevbox:/home/vagrant/kohaclone (BZ17047_s) ✹ ✭]% prove -r
> t/db_dependent/Koha/SharedContent.t t/db_dependent/Koha/Subscription*
> t/db_dependent/Serial*
> t/db_dependent/Koha/SharedContent.t ................ Name
> "Koha::SharedContent::MANA_IP" used only once: possible typo at
> t/db_dependent/Koha/SharedContent.t line 44.
> 
> t/db_dependent/Koha/Subscription.t ................. "my" variable $builder
> masks earlier declaration in same scope at
> t/db_dependent/Koha/Subscription.t line 38.
> t/db_dependent/Koha/Subscription.t ................. 1/9 Can't call method
> "biblionumber" on an undefined value at
> /home/vagrant/kohaclone/Koha/Subscription.pm line 143.
> # Looks like your test exited with 255 just after 8.
> t/db_dependent/Koha/Subscription.t ................. Dubious, test returned
> 255 (wstat 65280, 0xff00)
> Failed 1/9 subtests 
> 
> t/db_dependent/Serials/ReNewSubscription.t ......... Undefined subroutine
> &Koha::SharedContent::manaGetRequestWithId called at
> /home/vagrant/kohaclone/C4/Serials.pm line 303.
> 
> 
> 2. QA script:
> 
>  FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt
>    FAIL   forbidden patterns
>                 forbidden pattern: Do *not* include full path to js files,
> use the Asset TT plugin (bug 20538) (line 196)
>                 forbidden pattern: intranet-tmpl should certainly replaced
> with [% interface %] (line 196)
> 
> 
>  FAIL   t/db_dependent/Koha/SharedContent.t
>    FAIL   valid
>                 Name "Koha::SharedContent::MANA_IP" used only once: possible
> typo 
> 
>  FAIL   t/db_dependent/Koha/Subscription.t
>    FAIL   valid
>                 "my" variable $builder masks earlier declaration in same
> scope 
> 
> 
> About MANA_IP, you should move it to a Koha::SharedContent method. It would
> be the only way to retrieve mana_config from the config.
> It will help to handle non-existent/invalid entry. Moreover I think we
> should avoid having config at package level (because of usage of Memcached
> and Plack). It will be easy to mock with mock_config.
> 
> 3. There is a CamelCase/snake_case mix in method's names

Fixed

-- 
You are receiving this mail because:
You are watching all bug changes.