[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #34 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Katrin Fischer from comment #29)
> QA scripts complain about missing POD:
>    FAIL	  pod coverage
> 		POD is missing for add_user
> 		POD is missing for duplicate_to
> 		POD is missing for items
> 		POD is missing for users

Added in the last follow-up.

> This looks a little odd:
> +        <label for="fund">Fund: </label>
> +        <select name="budget" id="fund">

Moved from acqui/histsearch.tt, existed before this patch.

> Wondering about missing |html filters, especially in
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/duplicate_orders.tt.

Added missing filters in a separate patch.

(In reply to Katrin Fischer from comment #30)
> Also, can you please explain the last patch?
> 
> Bug 15184: Add users ?
> 
> We certainly do not want this patch. What about users that are notified
> on receiving?

When an order is duplicated, do we want to duplicate the user list who were
notified on receiving? I.e. they will be notified on receiving items for the
duplicated order. I was not sure if it was wanted or not, so I put that code on
a separate patch and waited for a feedback.

-- 
You are receiving this mail because:
You are watching all bug changes.