[Koha-bugs] [Bug 21268] Can’t add to basket from staged file if base-level allocated is zero

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21268

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Ray Delahunty from comment #0)
> Since the fiscal period close we have been able to
> add to baskets using options OTHER than from a staged file.

Sure about that? It is not what I see:

acqui/addorderiso2709.pl:    if ( !defined $r->{budget_amount} ||
$r->{budget_amount} == 0 ) {
acqui/basket.pl:        if (!defined $r->{budget_amount} || $r->{budget_amount}
== 0) {
acqui/booksellers.pl:    if (!defined $r->{budget_amount} ||
$r->{budget_amount} == 0) {
acqui/neworderbiblio.pl:    if (!defined $r->{budget_amount} ||
$r->{budget_amount} == 0) {
acqui/neworderempty.pl:    if (!defined $r->{budget_amount} ||
$r->{budget_amount} <0) {
acqui/orderreceive.pl:        if ( !defined $r->{budget_amount} ||
$r->{budget_amount} == 0 ) {
acqui/parcels.pl:    if (!defined $r->{budget_amount} || $r->{budget_amount} ==
0) {


It's '== 0' vs '< 0'

So we we should fix neworderempty and replace '<0' with '== 0'

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.