[Koha-bugs] [Bug 21279] Transport cost matrix shows html entity in all empty cells

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21279

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
-                            <div class="enable_cost_input" data-cost-id="[%
bt.id | html %]">[% bt.disabled ? ' ' : bt.value | html %]</div>
+                            [% SET bt_value = ' ' %]
+                            [% UNLESS bt.disabled %][% bt_value = BLOCK %][%
bt.value | html %][% END %][% END %]
+                            <div class="enable_cost_input" data-cost-id="[%
bt.id | html %]">[% bt_value | $raw %]</div>

Looks overcomplicated to me. Assigning   to template vars does not seem
the way to go imo. No need to pass   to raw too. This is just regular
template contents.
Why not:

<div ..> [% IF bt.disabled %] [% ELSE %][% bt.value | html %]</div>

Looks simpler to me :) What do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.