From bugzilla-daemon at bugs.koha-community.org Sat Dec 1 11:06:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Dec 2018 10:06:13 +0000
Subject: [Koha-bugs] [Bug 21929] Typo in orderreceive.tt
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21929
--- Comment #3 from Andrew Isherwood ---
Apologies Pierre-Marc, a mistake on my part. I'm about to attach a fixed patch.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Dec 1 11:06:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Dec 2018 10:06:54 +0000
Subject: [Koha-bugs] [Bug 21929] Typo in orderreceive.tt
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21929
Andrew Isherwood changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Patch doesn't apply |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Dec 1 11:06:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Dec 2018 10:06:58 +0000
Subject: [Koha-bugs] [Bug 21929] Typo in orderreceive.tt
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21929
Andrew Isherwood changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #82796|0 |1
is obsolete| |
--- Comment #4 from Andrew Isherwood ---
Created attachment 82821
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82821&action=edit
Bug 21929 - Typo in orderreceive.tt
lass -> class
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Dec 1 11:07:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Dec 2018 10:07:29 +0000
Subject: [Koha-bugs] [Bug 21929] Typo in orderreceive.tt
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21929
--- Comment #5 from Andrew Isherwood ---
Test plan:
- Apply patch
- Load orderreceive.pl
=> TEST: Observe that the Unit Price hint has the "hint" class CSS applied
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Dec 1 16:43:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Dec 2018 15:43:05 +0000
Subject: [Koha-bugs] [Bug 21879] Code cleaning in printinvoice.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21879
Michal Denar changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |black23 at gmail.com
--- Comment #2 from Michal Denar ---
Hi,
any test plan?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Dec 1 18:12:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Dec 2018 17:12:09 +0000
Subject: [Koha-bugs] [Bug 529] Bug in updater when inserting new fields
(updatedatabase script)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=529
Alex Bernier changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |alex.bernier at braillenet.org
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Dec 1 18:20:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Dec 2018 17:20:41 +0000
Subject: [Koha-bugs] [Bug 21931] New: Upgrade from 3.22 to 18.11 fails when
running updatedatabase.pl script
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21931
Bug ID: 21931
Summary: Upgrade from 3.22 to 18.11 fails when running
updatedatabase.pl script
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Database
Assignee: koha-bugs at lists.koha-community.org
Reporter: alex.bernier at braillenet.org
QA Contact: testopia at bugs.koha-community.org
When upgrading from Koha 3.22 to 18.11, the DB update process
(updatedatabase.pl) fails with the following error message :
DBD::mysql::st execute failed: Unknown column 'me.weight' in 'field list' [for
Statement "SELECT `me`.`id`, `me`.`name`, `me`.`label`, `me`.`type`,
`me`.`weight` FROM `search_field` `me` WHERE ( `me`.`name` = ? )" with
ParamValues: 0='suppress'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line
1836.
DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column 'me.weight' in 'field
list' at /.../Koha/Objects.pm line 110
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Dec 1 18:39:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Dec 2018 17:39:31 +0000
Subject: [Koha-bugs] [Bug 21931] Upgrade from 3.22 to 18.11 fails when
running updatedatabase.pl script
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21931
Alex Bernier changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |alex.bernier at braillenet.org
--- Comment #1 from Alex Bernier ---
Created attachment 82822
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82822&action=edit
Fix updatedatabase.pl
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Dec 1 19:03:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Dec 2018 18:03:13 +0000
Subject: [Koha-bugs] [Bug 21931] Upgrade from 3.22 to 18.11 fails when
running updatedatabase.pl script
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21931
Alex Bernier changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Small patch
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Sat Dec 1 21:02:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Dec 2018 20:02:52 +0000
Subject: [Koha-bugs] [Bug 21932] New: reservetype and reserveexpiration
needed for holds (reserves and old_reserves tables)
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21932
Bug ID: 21932
Summary: reservetype and reserveexpiration needed for holds
(reserves and old_reserves tables)
Change sponsored?: ---
Product: Koha
Version: 17.05
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Hold requests
Assignee: koha-bugs at lists.koha-community.org
Reporter: cbrannon at cdalibrary.org
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com
I see an inherent flaw in the reserves table and process. If a hold is
waiting, and someone changes the status from waiting back to a priority level,
the waiting status is removed, but the expiration remains. Also, if the hold
was a first available hold, it is now changed to an item level hold for the
item it was on hold for.
I would suggest that a new field be created for the holds table, such as
reservetype, and is marked as 'ANY' or 'SPECIFIC'.
I would suggest that a new field be created for the reservation expiration
called reserveexpiration, separate from the waiting expiration, as to maintain
a reservation cutoff date if the status is changed back to a priority level.
This would make the expirationdate exclusive to waiting items.
I would suggest that when priority level is changed from waiting to a priority
level, the reservetype is checked, and if it is marked as ANY, the item number
be removed. If it is SPECIFIC, the item number is kept.
I would suggest that the expirationdate be cleared if changed from a waiting
status to a priority level.
I would suggest that all pages that show the "Expiration date" as the
reservationexpiration, if exists, or superseded by expirationdate, if exists.
No need to have a separate cell for both.
I would suggest that when a hold is triggered and marked as waiting, the
expiration date is calculated, or limited to the reservationexpiration,
whichever is shorter. No sense in holding it longer than the patron was
willing to wait for it.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Dec 1 21:16:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Dec 2018 20:16:21 +0000
Subject: [Koha-bugs] [Bug 21932] reservetype and reserveexpiration needed
for holds (reserves and old_reserves tables)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21932
--- Comment #1 from Christopher Brannon ---
To test flaws:
1) Place a first available hold for the next available item, and set the hold
expires date to a short time, like tomorrow.
2) Make sure your ReservesMaxPickUpDelay setting is set for longer that a day.
Say 7 days, for example.
3) View the hold. Note the expiration date is set.
4) Check in the item and trigger the hold. See that the item is waiting. Note
the expiration is set to the patron's preferred expiration date.
5) Set the priority back to 1, and update the hold. Note that the hold is now
an item specific hold instead of a next available hold.
6) Note the expiration stayed. This is okay in this instance.
7) Cancel the hold and start over.
8) Place a first available hold for the next available item, but do not set the
hold expires date.
9) View the hold. Note the expiration date is not set.
10) Check in the item and trigger the hold. See that the item is waiting. Not
the expiration date is set.
11) Set the priority back to 1, and update the hold. Note that the hold is now
an item specific hold instead of a next available hold.
12) Note the expiration stayed. This is not okay in this instance. The
patron's hold will disappear after the date!
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Dec 1 21:18:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Dec 2018 20:18:06 +0000
Subject: [Koha-bugs] [Bug 21932] reservetype and reserveexpiration needed
for holds (reserves and old_reserves tables)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21932
--- Comment #2 from Christopher Brannon ---
It is noted that the waiting expiration date DOES adhere to the patron's
suggested expiration, but I have spelled it out in my suggestions to maintain
that behavior if the dates are recorded separately.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Sat Dec 1 22:21:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Dec 2018 21:21:35 +0000
Subject: [Koha-bugs] [Bug 16260] Moderate the impact of
AllowHoldsOnPatronsPossessions
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16260
Christopher Brannon changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|enhancement |major
CC| |cbrannon at cdalibrary.org
--- Comment #1 from Christopher Brannon ---
I agree that this AllowHoldsOnPatronsPossessions is a problem.
Currently, we have certain records that we allow mulitple holds on. The patron
cannot place a hold on one of these items if they have something on that record
checkout out and AllowHoldsOnPatronsPossessions is set to Don't allow. This
preference needs to take into account circ rules that allow multiple holds on a
record.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Sun Dec 2 20:23:44 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Dec 2018 19:23:44 +0000
Subject: [Koha-bugs] [Bug 19288] Holds placed on a specific item after a
next available hold will show varied results
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19288
Michal Denar changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |black23 at gmail.com
--- Comment #7 from Michal Denar ---
Please rebase on master.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 00:16:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Dec 2018 23:16:39 +0000
Subject: [Koha-bugs] [Bug 21887] 856$u link problem in XSLT result lists and
detail page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21887
--- Comment #8 from David Cook ---
(In reply to Devinim from comment #7)
> Hi David,
> Can you share a sample for malformed but functional URL?
> Thanks.
Sure, I was thinking something like
"koha-community.org?redirect=http://other-site.org"
That string would not be caught by this test:
Apologies for my wording of "malformed but functional URL". What I meant was a
a URL missing a scheme but containing an unencoded URL in the query string.
Technically, the value of redirect should be encoded, but browsers will
typically work with it anyway. If I put
"koha-community.org?redirect=http://other-site.org" into a Chrome browser,
it'll work. But according to your use case, it will try to connect to
localhost.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 00:35:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Dec 2018 23:35:58 +0000
Subject: [Koha-bugs] [Bug 21872] Elasticsearch indexing faster by making it
multi-threaded
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21872
--- Comment #32 from David Cook ---
(In reply to Ere Maijala from comment #31)
> Ok, so what do you think about the latest one? Should be pretty
> straight-forward to use and no new dependencies required.
Apologies for my earlier comments. Please don't feel obligated to use forking
just because of my suggestions!
Actually, I just noticed that misc/search_tools/rebuild_elastic_search.pl
doesn't have a lock file, which seems problematic but predates this patch.
Logging should be fine since the child processes should inherit the STDOUT file
handle...
I don't have an Elasticsearch on hand for testing but looks workable at a
glance.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 01:18:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 00:18:45 +0000
Subject: [Koha-bugs] [Bug 20630] An attempt at multitenancy with Mojolicious
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20630
--- Comment #4 from David Cook ---
(In reply to Jerome Charaoui from comment #3)
> Created attachment 76218 [details] [review]
> bug 20630: Various improvements
>
> Thank you for this patch. I've done some testing with it and it appears to
> work great. Compared to Plack, this method is much more efficient and less
> memory-hungry when running multiple instances. I'm currently using it to run
> 20 instances on a VM with 4GB of RAM, and will soon test with 120 instances
> on the same host. I'll be sure to report any further issues and results here.
>
Hi Jerome, how has your system been going for these last 5 months?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 02:07:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 01:07:20 +0000
Subject: [Koha-bugs] [Bug 20630] An attempt at multitenancy with Mojolicious
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20630
--- Comment #5 from Jerome Charaoui ---
Ha David, I've been reporting my progress mainly on bug 20582. In short: it
works well, although there are some quirks to work out.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 10:11:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 09:11:19 +0000
Subject: [Koha-bugs] [Bug 21933] New: Renew or chek in selected items
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21933
Bug ID: 21933
Summary: Renew or chek in selected items
Change sponsored?: ---
Product: Koha
Version: master
Hardware: HP
OS: Linux
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: bugs.koha-community.org
Assignee: koha-bugs at lists.koha-community.org
Reporter: sergeinik at tut.by
QA Contact: testopia at bugs.koha-community.org
Created attachment 82823
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82823&action=edit
Russian interface
After the last update, when viewing the user's literature list from the
administrator interface, the output of information hangs if the biblographic
records are old enough. For new entries, everything is working fine. If the
user has old and new entries in the list, the interface also hangs.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 14:10:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 13:10:40 +0000
Subject: [Koha-bugs] [Bug 21405] Pagination in authorities search broken for
Zebra and broken for 10000+ results in ES
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21405
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 14:10:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 13:10:45 +0000
Subject: [Koha-bugs] [Bug 21405] Pagination in authorities search broken for
Zebra and broken for 10000+ results in ES
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21405
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #80158|0 |1
is obsolete| |
Attachment #80159|0 |1
is obsolete| |
--- Comment #13 from Nick Clemens ---
Created attachment 82824
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82824&action=edit
Bug 21405 - Fix auhtorities pagination for Zebra and ES
Bug 20261 introduced an error because search_auth_compat responded
differently for ES and Zebra, now bug 19365 fixed the underlying
difference. This patch restores previous code to fix pagination.
Additionally we add a fix for 10000+ results in ES and remove a double
import of C4::Auth
To test:
1 - Perform an authorities search with 1+ pages using Zebra
2 - Page through results, note you are only offseeting by 1 each time
3 - Perform an authorities search with 10,000+ results in ES
4 - Click on the last page and get an error
5 - Apply patch
6 - Retry Zebra search
7 - Results should paginate correctly
8 - Clicking on last page should return last results
9 - Retry ES results
10 - Results should paginate correct
11 - Clicking on last page should return last results
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 14:12:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 13:12:09 +0000
Subject: [Koha-bugs] [Bug 21405] Pagination in authorities search broken for
Zebra and broken for 10000+ results in ES
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21405
--- Comment #14 from Nick Clemens ---
(In reply to Martin Renvoize from comment #9)
> Should there not be a test accompanying this for
> Koha/SearchEngine/Elasticsearch/Search.pm search_auth_compat to ensure we
> don't get future regressions?
Rebased on top of 19365 - that added some basic tests, I have talked with Ere
and we agree we need to work towrds actual search testing, then we can add
selenium for this, but for now I think we need to fix this issue asap
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 15:20:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 14:20:42 +0000
Subject: [Koha-bugs] [Bug 21405] Pagination in authorities search broken for
Zebra and broken for 10000+ results in ES
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21405
--- Comment #15 from Martin Renvoize ---
I pretty much agree with the above.. perhaps a more concerted effort for
increasing search test coverage elsewhere and get this particular bug pushed
through.. I'm happy to go with that, and defer to Ere as ES Topic Expert (and
of course the RM, Nick)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 15:34:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 14:34:32 +0000
Subject: [Koha-bugs] [Bug 21934] New: Allow user to specify name for
'Shibboleth'
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21934
Bug ID: 21934
Summary: Allow user to specify name for 'Shibboleth'
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: koha-bugs at lists.koha-community.org
Reporter: nick at bywatersolutions.com
QA Contact: testopia at bugs.koha-community.org
Many sites using SAML (Shibboleth) don't refer to their login as a 'Shibboleth
login'
We shoudl make it easy for the user to specify what they call the service
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 15:51:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 14:51:00 +0000
Subject: [Koha-bugs] [Bug 21934] Allow user to specify name for 'Shibboleth'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21934
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
Patch complexity|--- |Trivial patch
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 15:51:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 14:51:03 +0000
Subject: [Koha-bugs] [Bug 21934] Allow user to specify name for 'Shibboleth'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21934
--- Comment #1 from Nick Clemens ---
Created attachment 82825
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82825&action=edit
Bug 21934 - Allow user to specify name for 'Shibboleth'
To test:
1 - Add a shibboleth config to your koha-conf.xml file (it does not need
to be valid)
1
userid
2 - Note on staff and user auth pages the message says "Shibboleth
account"
3 - Apply patch, update database
4 - Note login text has not changed
5 - Define a name in 'shibbolethName'
6 - Note it is reflected on all auth pages
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 15:51:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 14:51:08 +0000
Subject: [Koha-bugs] [Bug 21934] Allow user to specify name for 'Shibboleth'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21934
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
|ity.org |
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 15:52:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 14:52:00 +0000
Subject: [Koha-bugs] [Bug 21716] Item Search hangs when \ exists in MARC
fields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21716
Claire Gravely changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |claire_gravely at hotmail.com
|ity.org |
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 16:24:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 15:24:34 +0000
Subject: [Koha-bugs] [Bug 10659] Upgrade jQuery star ratings plugin
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10659
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |ASSIGNED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 17:10:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 16:10:09 +0000
Subject: [Koha-bugs] [Bug 10659] Upgrade jQuery star ratings plugin
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10659
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #82760|0 |1
is obsolete| |
--- Comment #18 from Owen Leonard ---
Created attachment 82826
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82826&action=edit
Bug 10659: Upgrade jQuery star ratings plugin
This patch replaces our current jQuery star ratings plugin with a newer
plugin which will be compatible with newer versions of jQuery:
http://antenna.io/demo/jquery-bar-rating/examples/
To test you should have one or more records in your catalog with star
ratings.
- Apply the patch and set the OpacStarRatings system preference
to "results and details"
- Perform a search in the catalog which will return one or more titles
which have ratings.
- Confirm that the ratings appear correctly and the ratings are
read-only.
- Open the "normal" detail page for that record.
- Confirm that the star rating appears correctly.
- Test setting and re-setting your star rating. Confirm that it is
saved.
- Confirm that the "cancel rating" link appears when you have a rating
set, and that it disappears after you click it.
- Test that the "only details" and disabled options of the
OpacStarRatings preference work as they should.
- Confirm that information about the plugin appears on the About page in
the staff client, replacing the old star ratings plugin information.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 17:10:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 16:10:06 +0000
Subject: [Koha-bugs] [Bug 10659] Upgrade jQuery star ratings plugin
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10659
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 17:22:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 16:22:52 +0000
Subject: [Koha-bugs] [Bug 21918] Update buttons on fines to match newer
buttons
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21918
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
|ity.org |
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 17:37:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 16:37:05 +0000
Subject: [Koha-bugs] [Bug 17140] Incorrect rounding in total fines
calculations, part 2
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=21673
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 17:37:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 16:37:05 +0000
Subject: [Koha-bugs] [Bug 21673] Koha::Account::Lines->total_outstanding
must be used when needed
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21673
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=17140
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 17:53:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 16:53:25 +0000
Subject: [Koha-bugs] [Bug 19288] Holds placed on a specific item after a
next available hold will show varied results
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19288
--- Comment #8 from Nick Clemens ---
(In reply to Michal Denar from comment #7)
> Please rebase on master.
Either patch seems to apply, you should not apply both, they are alternate
options
I suggest the second patch, but want opinions
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 18:09:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 17:09:57 +0000
Subject: [Koha-bugs] [Bug 21581] Matching rules for authorities do not
respect 'Search index' setting
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21581
Janusz Kaczmarek changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |---
CC| |januszop at gmail.com
--- Comment #12 from Janusz Kaczmarek ---
I seems to me that this patch creates a problem with Zebra searches while
queryparser is off.
Could you please verify the following scenario: search engine zebra, query
parser off, and let's do an authority search for e.g. authority number or
whatsoever with "Search entire record" (the forth option). Zebra gets the
query:
@or @attr 1=Heading @attr 7=1 0 @attr 4=6 @attr 5=1 @attr 1=all
and answers ERROR 114, that is unknown use attribute. In fact, the attr-1
'all' is not defined. Before that patch 'all' was changed into @attr 1=Any.
Now it seems to create problems.
Tests were done with 18.05.06.
Thank you for verifying this.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 18:21:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 17:21:07 +0000
Subject: [Koha-bugs] [Bug 21581] Matching rules for authorities do not
respect 'Search index' setting
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21581
--- Comment #13 from Janusz Kaczmarek ---
(In reply to Janusz Kaczmarek from comment #12)
> It seems to me that this patch creates a problem with Zebra searches while
> queryparser is off.
>
> Could you please verify the following scenario: search engine zebra, query
> parser off, and let's do an authority search for e.g. authority number or
> whatsoever with "Search entire record" (the forth option). Zebra gets the
> query:
>
> @or @attr 1=Heading @attr 7=1 0 @attr 4=6 @attr 5=1 @attr 1=all
>
> and answers ERROR 114, that is unknown use attribute. In fact, the attr-1
> 'all' is not defined. Before that patch 'all' was changed into @attr 1=Any.
> Now it seems to create problems.
>
> Tests were done with 18.05.06.
>
> Thank you for verifying this.
My fast work around is:
--- a/C4/AuthoritiesMarc.pm
+++ b/C4/AuthoritiesMarc.pm
@@ -163,6 +163,9 @@ sub SearchAuthorities {
elsif ( @$tags[$i] eq "thesaurus" ) {
$attr = " \@attr 1=Subject-heading-thesaurus ";
}
+ elsif ( @$tags[$i] eq "all" ) {
+ $attr = " \@attr 1=Any ";
+ }
else { # Use the index passed in params
$attr = " \@attr 1=" . @$tags[$i] . " ";
}
but I'm not sure if it wouldn't destruct the idea of the author of this patch,
so I'm not submitting it.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 19:19:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 18:19:41 +0000
Subject: [Koha-bugs] [Bug 21918] Clean up pay fines template
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21918
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Update buttons on fines to |Clean up pay fines template
|match newer buttons |
--- Comment #5 from Owen Leonard ---
I'd like to expand the scope of this bug to include:
- Styling the "Pay" and "Write off" buttons as Bootstrap buttons.
- Adding DataTables sorting, searching, and filtering.
- Adding a column showing the fine date.
- Hiding the "Add note" input, add a link to show it.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 19:21:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 18:21:08 +0000
Subject: [Koha-bugs] [Bug 21935] New: Setup sip accounts through front end
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21935
Bug ID: 21935
Summary: Setup sip accounts through front end
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: SIP2
Assignee: koha-bugs at lists.koha-community.org
Reporter: cbrannon at cdalibrary.org
QA Contact: testopia at bugs.koha-community.org
CC: colin.campbell at ptfs-europe.com
Currently, it is necessary to setup an account in Koha for a sip connection and
then do some setup for the same account on the backend (I do not know all the
details).
It would be great if there were a way to setup sip accounts via the patron
account, that would eliminate the need to monkey with stuff on the backend.
Ideally, it would be nice to have an area to setup sip accounts that is
separate from regular patron accounts.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 20:01:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 19:01:18 +0000
Subject: [Koha-bugs] [Bug 21918] Clean up pay fines template
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21918
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Small patch
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 20:01:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 19:01:22 +0000
Subject: [Koha-bugs] [Bug 21918] Clean up pay fines template
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21918
--- Comment #6 from Owen Leonard ---
Created attachment 82827
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82827&action=edit
Bug 21918: Update buttons on fines to match newer buttons
This patch makes a number of changes to the "Pay fines" template, the
goal of which is to make the interface look better in general. Changes
include:
- Styling the "Pay" and "Write off" buttons as Bootstrap buttons.
- Adding DataTables sorting, searching, and filtering.
- Adding a column showing the fine date.
- Hide the "Add note" input, add a link to show it.
- Add some missing "preventDefault" methods from events.
- Add "Writeoff selected" to the buttons which are disabled when there
is no checkbox selection.
- The tag is now expected by the HTML validator to be after
, so this section has been moved to suppress validator errors.
To test, apply the patch and locate a patron who has multiple
outstanding fines.
- Go to Fines -> Pay fines
- Confirm that the table of fines is shown as a DataTable, with sorting
on columns which have data.
- Confirm that fine dates are shown, and that sorting by this column
works correctly.
- Click an "Add note" link to show a note input field. Focus should be
in the newly-displayed input.
- Confirm that notes are still saved correctly when paying or writing
off single or multiple fines.
- Confirm that when the "add note" input is hidden, its contents are
erased.
- Uncheck all checkboxes by clicking the "Clear all" link at the top.
The "Pay selected" and "Write off selected" buttons should become
disabled.
- Checking any checkbox should re-enable those buttons.
- Test that the relocated "Apply" button (for outstanding credits)
still works as expected.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 20:09:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 19:09:39 +0000
Subject: [Koha-bugs] [Bug 21936] New: Patrons do not have option on printed
notices
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21936
Bug ID: 21936
Summary: Patrons do not have option on printed notices
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Notices
Assignee: koha-bugs at lists.koha-community.org
Reporter: cbrannon at cdalibrary.org
QA Contact: testopia at bugs.koha-community.org
Patrons do not have the ability to opt out of printed notices.
Right now, selecting the e-mail option is the only way to turn off printed
notices. Which is odd, because SMS doesn't do that.
I think we should do one of two things:
A) There should be a new column added to the patron messaging preferences that
show check marks for all notices in a print column, and allow the patrons to
opt out, like the others. E-mail should no longer negate printed.
B) Change the check box to a dropdown, and have the choices of Print only,
E-mail only, Both, or Neither. The column should be renamed Full Notice
(because SMS/phone are treated differently.
Personally, I think A is the better, straight forward choice. Less confusion.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 20:27:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 19:27:27 +0000
Subject: [Koha-bugs] [Bug 18677] issue_id is not added to accountlines for
lost item fees
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677
Jesse Maseto changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jesse at bywatersolutions.com
--- Comment #32 from Jesse Maseto ---
Back ported to 18.05.
Will be in 18.05.07 release.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 20:33:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 19:33:31 +0000
Subject: [Koha-bugs] [Bug 19865] Side scroll bar in z39.50 MARC view
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19865
Marjorie Barry-Vila changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |marjorie.barry-vila at collect
| |o.ca
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 20:42:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 19:42:26 +0000
Subject: [Koha-bugs] [Bug 15717] Installer: Step 3 has HTML tag br showing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15717
Bug 15717 depends on bug 13618, which changed state.
Bug 13618 Summary: Add additional template filter methods and a filter presence test to Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 20:42:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 19:42:26 +0000
Subject: [Koha-bugs] [Bug 21257] Patrons checkout table throws JS error when
location/collection not defined
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21257
Bug 21257 depends on bug 13618, which changed state.
Bug 13618 Summary: Add additional template filter methods and a filter presence test to Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 20:42:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 19:42:26 +0000
Subject: [Koha-bugs] [Bug 21293] Display of housebound delivery information
broken by Bug 13618
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21293
Bug 21293 depends on bug 13618, which changed state.
Bug 13618 Summary: Add additional template filter methods and a filter presence test to Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 20:42:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 19:42:27 +0000
Subject: [Koha-bugs] [Bug 21347] bad code for input field in item
information tab of addorderiso2709 page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21347
Bug 21347 depends on bug 13618, which changed state.
Bug 13618 Summary: Add additional template filter methods and a filter presence test to Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 20:42:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 19:42:27 +0000
Subject: [Koha-bugs] [Bug 21529] Fix display of HTML tags in print notices
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21529
Bug 21529 depends on bug 13618, which changed state.
Bug 13618 Summary: Add additional template filter methods and a filter presence test to Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 20:42:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 19:42:28 +0000
Subject: [Koha-bugs] [Bug 21576] Add a developer script to automatically fix
missing filters
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21576
Bug 21576 depends on bug 13618, which changed state.
Bug 13618 Summary: Add additional template filter methods and a filter presence test to Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 20:42:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 19:42:29 +0000
Subject: [Koha-bugs] [Bug 21905] Plugin hook
intranet_catalog_biblio_enhancements_toolbar_button incorrectly filtered
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21905
Bug 21905 depends on bug 13618, which changed state.
Bug 13618 Summary: Add additional template filter methods and a filter presence test to Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 20:42:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 19:42:29 +0000
Subject: [Koha-bugs] [Bug 14744] Cannot select guarantor when quote in one
of the fields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14744
Bug 14744 depends on bug 13618, which changed state.
Bug 13618 Summary: Add additional template filter methods and a filter presence test to Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 20:42:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 19:42:30 +0000
Subject: [Koha-bugs] [Bug 15733] Audio Alerts issues in master
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15733
Bug 15733 depends on bug 13618, which changed state.
Bug 13618 Summary: Add additional template filter methods and a filter presence test to Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 20:42:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 19:42:24 +0000
Subject: [Koha-bugs] [Bug 13618] Add additional template filter methods and
a filter presence test to Koha
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 20:42:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 19:42:30 +0000
Subject: [Koha-bugs] [Bug 15734] Audio Alerts broken
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15734
Bug 15734 depends on bug 13618, which changed state.
Bug 13618 Summary: Add additional template filter methods and a filter presence test to Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 20:42:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 19:42:31 +0000
Subject: [Koha-bugs] [Bug 15754] html tags displayed when editing frameworks
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15754
Bug 15754 depends on bug 13618, which changed state.
Bug 13618 Summary: Add additional template filter methods and a filter presence test to Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 20:42:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 19:42:31 +0000
Subject: [Koha-bugs] [Bug 20975] Improve auto escaping performance
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20975
Bug 20975 depends on bug 13618, which changed state.
Bug 13618 Summary: Add additional template filter methods and a filter presence test to Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 20:42:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 19:42:32 +0000
Subject: [Koha-bugs] [Bug 21377] Variable declarations erroneously filtered
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21377
Bug 21377 depends on bug 13618, which changed state.
Bug 13618 Summary: Add additional template filter methods and a filter presence test to Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 20:42:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 19:42:32 +0000
Subject: [Koha-bugs] [Bug 21393] Make template filter checks code reusable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21393
Bug 21393 depends on bug 13618, which changed state.
Bug 13618 Summary: Add additional template filter methods and a filter presence test to Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 20:42:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 19:42:32 +0000
Subject: [Koha-bugs] [Bug 21418] Incorrectly filtered markup in staff client
lists
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21418
Bug 21418 depends on bug 13618, which changed state.
Bug 13618 Summary: Add additional template filter methods and a filter presence test to Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 20:42:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 19:42:34 +0000
Subject: [Koha-bugs] [Bug 21454] Price filtered variables should not need to
be html filtered
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21454
Bug 21454 depends on bug 13618, which changed state.
Bug 13618 Summary: Add additional template filter methods and a filter presence test to Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 20:42:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 19:42:35 +0000
Subject: [Koha-bugs] [Bug 21293] Display of housebound delivery information
broken by Bug 13618
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21293
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
Status|Pushed to Master |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 20:42:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 19:42:35 +0000
Subject: [Koha-bugs] [Bug 21476] Incorrect filter prevents HTML5 media from
playing in the OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21476
Bug 21476 depends on bug 13618, which changed state.
Bug 13618 Summary: Add additional template filter methods and a filter presence test to Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 20:42:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 19:42:35 +0000
Subject: [Koha-bugs] [Bug 21526] TT variables used to build a link should be
uri filtered
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21526
Bug 21526 depends on bug 13618, which changed state.
Bug 13618 Summary: Add additional template filter methods and a filter presence test to Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 20:42:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 19:42:36 +0000
Subject: [Koha-bugs] [Bug 21541] HTML filter breaks HTML rendering of SQL
output
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21541
Bug 21541 depends on bug 13618, which changed state.
Bug 13618 Summary: Add additional template filter methods and a filter presence test to Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 20:42:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 19:42:37 +0000
Subject: [Koha-bugs] [Bug 21663] Incorrect filter prevents predefined notes
from being added to patron acccounts
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21663
Bug 21663 depends on bug 13618, which changed state.
Bug 13618 Summary: Add additional template filter methods and a filter presence test to Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 20:42:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 19:42:37 +0000
Subject: [Koha-bugs] [Bug 21669] TT assignment statements must not be html
filtered
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21669
Bug 21669 depends on bug 13618, which changed state.
Bug 13618 Summary: Add additional template filter methods and a filter presence test to Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 20:42:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 19:42:37 +0000
Subject: [Koha-bugs] [Bug 21703] Placing holds in staff is broken (TT filter)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21703
Bug 21703 depends on bug 13618, which changed state.
Bug 13618 Summary: Add additional template filter methods and a filter presence test to Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 20:42:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 19:42:38 +0000
Subject: [Koha-bugs] [Bug 21704] Editing subfields in bibliographic
frameworks is broken (TT filter)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21704
Bug 21704 depends on bug 13618, which changed state.
Bug 13618 Summary: Add additional template filter methods and a filter presence test to Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 20:42:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 19:42:38 +0000
Subject: [Koha-bugs] [Bug 21706] Editing subfields in authority frameworks
is broken (TT filter)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706
Bug 21706 depends on bug 13618, which changed state.
Bug 13618 Summary: Add additional template filter methods and a filter presence test to Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 20:43:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 19:43:08 +0000
Subject: [Koha-bugs] [Bug 21347] bad code for input field in item
information tab of addorderiso2709 page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21347
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|Pushed to Master |RESOLVED
CC| |katrin.fischer at bsz-bw.de
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 20:43:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 19:43:29 +0000
Subject: [Koha-bugs] [Bug 21257] Patrons checkout table throws JS error when
location/collection not defined
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21257
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|Pushed to Master |RESOLVED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 20:51:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 19:51:35 +0000
Subject: [Koha-bugs] [Bug 21918] Clean up pay fines template
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21918
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |ASSIGNED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 20:51:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 19:51:45 +0000
Subject: [Koha-bugs] [Bug 21918] Clean up pay fines template
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21918
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #82827|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 20:52:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 19:52:22 +0000
Subject: [Koha-bugs] [Bug 21918] Clean up pay fines template
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21918
--- Comment #7 from Owen Leonard ---
Withdrawing this patch because it's missing columns settings configuration.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 21:25:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 20:25:34 +0000
Subject: [Koha-bugs] [Bug 21778] Sorting is inconsistent on patron search
based on permissions
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21778
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |josef.moravec at gmail.com
--- Comment #3 from Josef Moravec ---
Nick,
if we want the sorting to be always consistant, why not to even remove the
whole condition?
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 21:26:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 20:26:41 +0000
Subject: [Koha-bugs] [Bug 21794] Incomplete address displayed on patron
details page when City field is empty
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21794
Marjorie Barry-Vila changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |marjorie.barry-vila at collect
| |o.ca
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 21:29:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 20:29:51 +0000
Subject: [Koha-bugs] [Bug 21778] Sorting is inconsistent on patron search
based on permissions
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21778
--- Comment #4 from Nick Clemens ---
if they have neither of those permissions there won't be the extra column, we
will sort by the first column so we need the test to know if we wort on index 1
or 2
if we can name the column using class or something for sort instead of using
the index that could avoid the conditions
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 21:33:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 20:33:28 +0000
Subject: [Koha-bugs] [Bug 21934] Allow user to specify name for 'Shibboleth'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21934
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #2 from Katrin Fischer ---
Patches like these are problematic, because they make the text mono-lingual and
harder to translate as we will be missing context.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 21:50:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 20:50:52 +0000
Subject: [Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix
waiting holds at wrong location bug
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |josef.moravec at gmail.com
Hardware|All |Macintosh
QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
|y.org |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 21:54:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 20:54:04 +0000
Subject: [Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix
waiting holds at wrong location bug
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--- Comment #42 from Josef Moravec ---
Overall it looks good, just one thing - please don't use inline javascript
(onclick="...")
And could you please separate the fix for rerouting wating hold to its own bug
report?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 21:54:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 20:54:47 +0000
Subject: [Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix
waiting holds at wrong location bug
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346
--- Comment #43 from Josef Moravec ---
(In reply to Josef Moravec from comment #42)
>
> And could you please separate the fix for rerouting wating hold to its own
> bug report?
And it would be nice to have regression test here...
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 21:57:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 20:57:33 +0000
Subject: [Koha-bugs] [Bug 21937] New: Syspref autoBarcode annual doesn't
increment properly barcode in some cases
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21937
Bug ID: 21937
Summary: Syspref autoBarcode annual doesn't increment properly
barcode in some cases
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Cataloging
Assignee: koha-bugs at lists.koha-community.org
Reporter: frederic at tamil.fr
QA Contact: testopia at bugs.koha-community.org
CC: m.de.rooy at rijksmuseum.nl
When autoBarcode is set to 'annual', and there is an existing barcode beginning
with the 4 digit of the current year, the auto generated barcode may be wrong.
For example, you have this barcode '20184526546'. If you ask for the next
2018-000X barcode, you will 20184526547
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 22:01:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 21:01:47 +0000
Subject: [Koha-bugs] [Bug 21937] Syspref autoBarcode annual doesn't
increment properly barcode in some cases
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21937
Fr?d?ric Demians changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Trivial patch
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 22:01:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 21:01:50 +0000
Subject: [Koha-bugs] [Bug 21937] Syspref autoBarcode annual doesn't
increment properly barcode in some cases
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21937
--- Comment #1 from Fr?d?ric Demians ---
Created attachment 82828
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82828&action=edit
Bug 21937: Syspref autoBarcode annual doesn't increment properly barcode in
some cases
This patch show the issue. If the DB contains a barcode (not auto attributed
by Koha) which begin with the year used to generate automatically a new one,
there may be a 'collision'.
prove -v t/db_dependent/Barcodes_ValueBuilder.t
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 22:03:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 21:03:04 +0000
Subject: [Koha-bugs] [Bug 21937] Syspref autoBarcode annual doesn't
increment properly barcode in some cases
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21937
--- Comment #2 from Fr?d?ric Demians ---
Created attachment 82829
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82829&action=edit
Bug 21937: syspref autoBarcode annual doesn't increment properly barcode
This patch fix the barcode annual builder. The test wil work.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 22:20:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 21:20:57 +0000
Subject: [Koha-bugs] [Bug 21938] New: Add biblio information to credits on
cash register
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21938
Bug ID: 21938
Summary: Add biblio information to credits on cash register
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Reports
Assignee: koha-bugs at lists.koha-community.org
Reporter: addie at bywatersolutions.com
QA Contact: testopia at bugs.koha-community.org
There is not currently a linkage between credits/payments on the cash register
report to it's corresponding biblio/item.
The biblio information is only linked to the charges.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 22:27:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 21:27:28 +0000
Subject: [Koha-bugs] [Bug 21933] Renew or chek in selected items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21933
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #1 from Katrin Fischer ---
Have you cleared your browser cache after the update?
As this is done with JavaScript - is there a JavaScript error in the browser's
developer tools you could share?
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 22:29:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 21:29:38 +0000
Subject: [Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix
waiting holds at wrong location bug
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346
--- Comment #44 from Christopher Brannon ---
(In reply to Josef Moravec from comment #43)
> (In reply to Josef Moravec from comment #42)
> >
> > And could you please separate the fix for rerouting wating hold to its own
> > bug report?
>
> And it would be nice to have regression test here...
I don't know what that is.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 22:56:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 21:56:19 +0000
Subject: [Koha-bugs] [Bug 21939] New: Permissions for Holds History Tab
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939
Bug ID: 21939
Summary: Permissions for Holds History Tab
Change sponsored?: ---
Product: Koha
Version: 18.05
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Patrons
Assignee: koha-bugs at lists.koha-community.org
Reporter: jzairo at bywatersolutions.com
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
With bug 14919 we added the availability to allow staff to view the Holds
History tab for a patron if intranetreadinghistory is set to allow. However,
depending on the permissions, a staff member has they may or may not be able to
see. In order to view the Holds History Tab a staff member must have the full
borrowers permission.
borrowers Add, modify and view patron information
edit_borrowers Add, modify and view patron information
view_borrower_infos_from_any_libraries View patron info from any libraries. If
not set the logged in user could only access patron info from its own library
or group of libraries.
If they only have edit_borrowers Add, modify and view patron information, they
will not have access to view the Holds History tab.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Dec 3 22:56:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 21:56:36 +0000
Subject: [Koha-bugs] [Bug 21939] Permissions for Holds History Tab
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939
Jessie Zairo changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |nick at bywatersolutions.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 00:55:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Dec 2018 23:55:39 +0000
Subject: [Koha-bugs] [Bug 21940] New: Query parameters of the form <> return no results.
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21940
Bug ID: 21940
Summary: Query parameters of the form <> return no
results.
Change sponsored?: ---
Product: Koha
Version: 18.05
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Reports
Assignee: koha-bugs at lists.koha-community.org
Reporter: barton at bywatersolutions.com
QA Contact: testopia at bugs.koha-community.org
Running the following report
select
cardnumber,
firstname,
surname,
categorycode
from borrowers
where categorycode = <>
returns no results. Inspecting 'Show SQL' reveals
select
cardnumber,
firstname,
surname,
categorycode
from borrowers
where categorycode = NULL
however
where categorycode = <>
and
where categorycode = <<"s">>
both work.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 07:02:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 06:02:05 +0000
Subject: [Koha-bugs] [Bug 21405] Pagination in authorities search broken for
Zebra and broken for 10000+ results in ES
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21405
Ere Maijala changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 07:02:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 06:02:10 +0000
Subject: [Koha-bugs] [Bug 21405] Pagination in authorities search broken for
Zebra and broken for 10000+ results in ES
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21405
--- Comment #16 from Ere Maijala ---
Created attachment 82830
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82830&action=edit
Bug 21405 - Fix authorities pagination for Zebra and ES
Bug 20261 introduced an error because search_auth_compat responded
differently for ES and Zebra, now bug 19365 fixed the underlying
difference. This patch restores previous code to fix pagination.
Additionally we add a fix for 10000+ results in ES and remove a double
import of C4::Auth
To test:
1 - Perform an authorities search with 1+ pages using Zebra
2 - Page through results, note you are only offseeting by 1 each time
3 - Perform an authorities search with 10,000+ results in ES
4 - Click on the last page and get an error
5 - Apply patch
6 - Retry Zebra search
7 - Results should paginate correctly
8 - Clicking on last page should return last results
9 - Retry ES results
10 - Results should paginate correct
11 - Clicking on last page should return last results
Signed-off-by: Ere Maijala
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 07:02:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 06:02:49 +0000
Subject: [Koha-bugs] [Bug 21405] Pagination in authorities search broken for
Zebra and broken for 10000+ results in ES
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21405
Ere Maijala changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #82824|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 07:04:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 06:04:24 +0000
Subject: [Koha-bugs] [Bug 21405] Pagination in authorities search broken for
Zebra and broken for 10000+ results in ES
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21405
--- Comment #17 from Ere Maijala ---
I took the liberty of removing addition of "use POSIX qw(ceil);" since it
wasn't actually used.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 07:09:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 06:09:05 +0000
Subject: [Koha-bugs] [Bug 21879] Code cleaning in printinvoice.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21879
--- Comment #3 from Devinim ---
Hi Michal,
This patch depends on the patch of Bug 19489.
After applying patch 19489 and test all steps you should apply this and then
check whether it is working as expected.
Thanks.
Devinim Koha Team
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 07:19:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 06:19:13 +0000
Subject: [Koha-bugs] [Bug 21933] Renew or chek in selected items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21933
--- Comment #2 from sergeinik ---
1. This is not related to the browser cache, since the problem recurs in any
browser and on any computer.
2. JavaScript errors:
checkouts_18.1100000.js:310 Uncaught TypeError: Cannot read property
'escapeHtml' of null
at mDataProp (checkouts_18.1100000.js:310)
at jquery.dataTables.min_18.1100000.js:18
at Object.b.fnGetData (jquery.dataTables.min_18.1100000.js:12)
at B (jquery.dataTables.min_18.1100000.js:16)
at Ja (jquery.dataTables.min_18.1100000.js:24)
at N (jquery.dataTables.min_18.1100000.js:16)
at jquery.dataTables.min_18.1100000.js:48
at i (jquery.dataTables.min_18.1100000.js:35)
at Object.success (checkouts_18.1100000.js:514)
at i (jquery-2.2.3.min_18.1100000.js:2)
mDataProp @ checkouts_18.1100000.js:310
(anonymous) @ jquery.dataTables.min_18.1100000.js:18
b.fnGetData @ jquery.dataTables.min_18.1100000.js:12
B @ jquery.dataTables.min_18.1100000.js:16
Ja @ jquery.dataTables.min_18.1100000.js:24
N @ jquery.dataTables.min_18.1100000.js:16
(anonymous) @ jquery.dataTables.min_18.1100000.js:48
i @ jquery.dataTables.min_18.1100000.js:35
(anonymous) @ checkouts_18.1100000.js:514
i @ jquery-2.2.3.min_18.1100000.js:2
fireWith @ jquery-2.2.3.min_18.1100000.js:2
z @ jquery-2.2.3.min_18.1100000.js:4
(anonymous) @ jquery-2.2.3.min_18.1100000.js:4
load (async)
send @ jquery-2.2.3.min_18.1100000.js:4
ajax @ jquery-2.2.3.min_18.1100000.js:4
n.(anonymous function) @ jquery-2.2.3.min_18.1100000.js:4
getJSON @ jquery-2.2.3.min_18.1100000.js:4
fnServerData @ checkouts_18.1100000.js:513
ra @ jquery.dataTables.min_18.1100000.js:36
ia @ jquery.dataTables.min_18.1100000.js:48
(anonymous) @ jquery.dataTables.min_18.1100000.js:95
each @ jquery-2.2.3.min_18.1100000.js:2
each @ jquery-2.2.3.min_18.1100000.js:2
m @ jquery.dataTables.min_18.1100000.js:85
KohaTable @ moremember.pl?borrowernumber=30:1324
LoadIssuesTable @ checkouts_18.1100000.js:184
(anonymous) @ checkouts_18.1100000.js:166
dispatch @ jquery-2.2.3.min_18.1100000.js:3
r.handle @ jquery-2.2.3.min_18.1100000.js:3
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 07:55:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 06:55:08 +0000
Subject: [Koha-bugs] [Bug 21405] Pagination in authorities search broken for
Zebra and broken for 10000+ results in ES
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21405
Ere Maijala changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--- Comment #18 from Ere Maijala ---
Oops, I didn't test the pagination fix properly. It's not working. I get 1822
pages of results and trying to go to the last page causes an error. It seems
that $hits_to_paginate is not being used.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 09:11:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 08:11:19 +0000
Subject: [Koha-bugs] [Bug 21933] Renew or chek in selected items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21933
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|enhancement |normal
Hardware|HP |All
Component|bugs.koha-community.org |Circulation
OS|Linux |All
CC| |gmcharlt at gmail.com,
| |kyle.m.hall at gmail.com
--- Comment #3 from Katrin Fischer ---
Sometimes things break from translation - does the problem appear with the
English templates as well? What version did you update to?
I can't test right now, but this might help to narrow it down a bit more.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 09:24:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 08:24:14 +0000
Subject: [Koha-bugs] [Bug 21933] Renew or chek in selected items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21933
--- Comment #4 from sergeinik ---
Both with English and with Russian interfaces the same problem. We have a
Russian version.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 09:48:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 08:48:49 +0000
Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
more granular level
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Stefan Berndtsson changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |stefan.berndtsson at ub.gu.se
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 13:07:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 12:07:50 +0000
Subject: [Koha-bugs] [Bug 21206] C4::Items - Remove GetItem
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 13:07:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 12:07:54 +0000
Subject: [Koha-bugs] [Bug 21206] C4::Items - Remove GetItem
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #78153|0 |1
is obsolete| |
Attachment #78154|0 |1
is obsolete| |
Attachment #78155|0 |1
is obsolete| |
--- Comment #15 from Josef Moravec ---
Created attachment 82831
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82831&action=edit
Bug 21206: Replace C4::Items::GetItem
Note: This is here for information purpose, feel free to test it if you
wan to play with it.
TODO: C4::Reserves::_get_itype is not longer in use
No more GetItem must be returned by:
git grep GetItem|grep -v GetItemsAvailableToFillHoldRequestsForBib|grep
-v GetItemsForInventory|grep -v GetItemsInfo|grep -v
GetItemsLocationInfo|grep -v GetItemsInCollection|grep -v
GetItemCourseReservesInfo|grep -v GetItemnumbersFromOrder|grep -v
GetItemSearchField|grep -v GetItemTypesCategorized|grep -v
GetItemNumbersFromImportBatch|cut -d':' -f1|sort|uniq
Signed-off-by: Josef Moravec
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 13:07:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 12:07:58 +0000
Subject: [Koha-bugs] [Bug 21206] C4::Items - Remove GetItem
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206
--- Comment #16 from Josef Moravec ---
Created attachment 82832
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82832&action=edit
Bug 21206: Remove GetItem
Signed-off-by: Josef Moravec
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 13:08:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 12:08:02 +0000
Subject: [Koha-bugs] [Bug 21206] C4::Items - Remove GetItem
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206
--- Comment #17 from Josef Moravec ---
Created attachment 82833
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82833&action=edit
Bug 21206: Fix Returns.t
we are calling several times effective_itemtype
Must be fixed later
Signed-off-by: Josef Moravec
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 13:08:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 12:08:06 +0000
Subject: [Koha-bugs] [Bug 21206] C4::Items - Remove GetItem
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206
--- Comment #18 from Josef Moravec ---
Created attachment 82834
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82834&action=edit
Bug 21206: (follow-up) Fix Circulation.t
Test plan:
prove t/db_dependent/Circulation.t
Signed-off-by: Josef Moravec
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 14:08:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 13:08:48 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
daemon that can inject item status MARC subfields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937
Ere Maijala changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #66943|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 14:08:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 13:08:56 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
daemon that can inject item status MARC subfields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937
Ere Maijala changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #66944|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 14:09:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 13:09:02 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
daemon that can inject item status MARC subfields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937
Ere Maijala changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #66945|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 14:09:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 13:09:08 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
daemon that can inject item status MARC subfields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937
Ere Maijala changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #66946|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 14:09:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 13:09:27 +0000
Subject: [Koha-bugs] [Bug 13937] Add a search backend agnostic Z39.50/SRU
daemon that can inject item status MARC subfields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937
Ere Maijala changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #69139|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 14:18:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 13:18:04 +0000
Subject: [Koha-bugs] [Bug 19489] Development for fines and Fees Module -
Detailed Description of charges in Patron Account Tab/Fines Tab
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
--- Comment #9 from Owen Leonard ---
This seems to be working, but the test doesn't pass:
t/db_dependent/Koha/Account/Lines.t .. 1/5
# Failed test 'No tests run for subtest "item() tests"'
# at t/db_dependent/Koha/Account/Lines.t line 67.
DBIx::Class::Storage::DBI::_dbh_execute(): Field 'account_balance' doesn't have
a default value at /home/vagrant/kohaclone/t/lib/TestBuilder.pm line 288
# Looks like your test exited with 255 just after 1.
t/db_dependent/Koha/Account/Lines.t .. Dubious, test returned 255 (wstat 65280,
0xff00)
Failed 5/5 subtests
Test Summary Report
-------------------
t/db_dependent/Koha/Account/Lines.t (Wstat: 65280 Tests: 1 Failed: 1)
Failed test: 1
Non-zero exit status: 255
Parse errors: Bad plan. You planned 5 tests but ran 1.
Files=1, Tests=1, 3 wallclock secs ( 0.01 usr 0.01 sys + 1.21 cusr 0.52
csys = 1.75 CPU)
Result: FAIL
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 14:32:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 13:32:33 +0000
Subject: [Koha-bugs] [Bug 19489] Development for fines and Fees Module -
Detailed Description of charges in Patron Account Tab/Fines Tab
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489
--- Comment #10 from Devinim ---
Hi Owen,
It is most probably another patch made it this since we've tested before
sending patches and unit tests.
Our developers is looking once again, will change it soon.
Thanks a lot.
Devinim Koha Team
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 14:33:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 13:33:13 +0000
Subject: [Koha-bugs] [Bug 21885] Calendar to-date starts before end-date
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21885
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
Patch complexity|--- |Small patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 14:33:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 13:33:16 +0000
Subject: [Koha-bugs] [Bug 21885] Calendar to-date starts before end-date
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21885
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #82659|0 |1
is obsolete| |
--- Comment #3 from Owen Leonard ---
Created attachment 82835
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82835&action=edit
Bug 21885: Calendar to-date starts before end-date
When adding new holidays to the calendar, you pick the start date,
and then the end date, but the end date calendar will start from
current date, not from the picked start date. Sometimes this means
many extra clicks to pick an end date.
Make the end date calendar start from the beginning date by default.
Test plan:
1) Go to the tools -> calendar
2) Pick a start date somewhere in the future, and then open the
end date calendar. Notice how it starts before the start date
of the date range.
3) Apply patch.
4) Pick a start date in the future. The end date calendar should
automatically default to the same date.
5) Change the start date a day backwards, note how the end date
does not change.
6) Change the start date after the end date, note how the end date
adjusts, so it is not in the past.
Signed-off-by: Pasi Kallinen
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 14:34:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 13:34:27 +0000
Subject: [Koha-bugs] [Bug 21885] Calendar to-date starts before end-date
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21885
--- Comment #4 from Owen Leonard ---
A nice follow-up to this would be to disable dates before the chosen start
date.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 14:38:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 13:38:28 +0000
Subject: [Koha-bugs] [Bug 21929] Typo in orderreceive.tt
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21929
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #82821|0 |1
is obsolete| |
--- Comment #6 from Owen Leonard ---
Created attachment 82836
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82836&action=edit
Bug 21929 - Typo in orderreceive.tt
lass -> class
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 14:38:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 13:38:25 +0000
Subject: [Koha-bugs] [Bug 21929] Typo in orderreceive.tt
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21929
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 14:44:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 13:44:55 +0000
Subject: [Koha-bugs] [Bug 21929] Typo in orderreceive.tt
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21929
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 14:44:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 13:44:59 +0000
Subject: [Koha-bugs] [Bug 21929] Typo in orderreceive.tt
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21929
--- Comment #7 from Marcel de Rooy ---
Created attachment 82837
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82837&action=edit
Bug 21929: Typo in orderreceive.tt
lass -> class
Signed-off-by: Owen Leonard
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 14:45:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 13:45:17 +0000
Subject: [Koha-bugs] [Bug 21405] Pagination in authorities search broken for
Zebra and broken for 10000+ results in ES
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21405
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 14:45:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 13:45:21 +0000
Subject: [Koha-bugs] [Bug 21405] Pagination in authorities search broken for
Zebra and broken for 10000+ results in ES
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21405
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #82830|0 |1
is obsolete| |
--- Comment #19 from Nick Clemens ---
Created attachment 82838
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82838&action=edit
Bug 21405 - Fix authorities pagination for Zebra and ES
Bug 20261 introduced an error because search_auth_compat responded
differently for ES and Zebra, now bug 19365 fixed the underlying
difference. This patch restores previous code to fix pagination.
Additionally we add a fix for 10000+ results in ES and remove a double
import of C4::Auth
To test:
1 - Perform an authorities search with 1+ pages using Zebra
2 - Page through results, note you are only offseeting by 1 each time
3 - Perform an authorities search with 10,000+ results in ES
4 - Click on the last page and get an error
5 - Apply patch
6 - Retry Zebra search
7 - Results should paginate correctly
8 - Clicking on last page should return last results
9 - Retry ES results
10 - Results should paginate correct
11 - Clicking on last page should return last results
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 14:45:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 13:45:28 +0000
Subject: [Koha-bugs] [Bug 21929] Typo in orderreceive.tt
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21929
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
|y.org |
CC| |m.de.rooy at rijksmuseum.nl
--- Comment #8 from Marcel de Rooy ---
Fixed qa tools warn:
* Commit title does not start with 'Bug XXXXX: ' - b54d50a
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 14:50:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 13:50:49 +0000
Subject: [Koha-bugs] [Bug 15422] Number of items to order on holds ratio
report will not fulfill the holds ratio.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15422
--- Comment #2 from Owen Leonard ---
> 8 - Run with HR=3, order 1, OK
I get "No items found" in this case. Is that a bug?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 15:13:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 14:13:35 +0000
Subject: [Koha-bugs] [Bug 21405] Pagination in authorities search broken for
Zebra and broken for 10000+ results in ES
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21405
Ere Maijala changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #82838|0 |1
is obsolete| |
--- Comment #20 from Ere Maijala ---
Created attachment 82839
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82839&action=edit
Bug 21405 - Fix authorities pagination for Zebra and ES
Bug 20261 introduced an error because search_auth_compat responded
differently for ES and Zebra, now bug 19365 fixed the underlying
difference. This patch restores previous code to fix pagination.
Additionally we add a fix for 10000+ results in ES and remove a double
import of C4::Auth
To test:
1 - Perform an authorities search with 1+ pages using Zebra
2 - Page through results, note you are only offseeting by 1 each time
3 - Perform an authorities search with 10,000+ results in ES
4 - Click on the last page and get an error
5 - Apply patch
6 - Retry Zebra search
7 - Results should paginate correctly
8 - Clicking on last page should return last results
9 - Retry ES results
10 - Results should paginate correct
11 - Clicking on last page should return last results
Signed-off-by: Ere Maijala
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 15:14:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 14:14:12 +0000
Subject: [Koha-bugs] [Bug 21405] Pagination in authorities search broken for
Zebra and broken for 10000+ results in ES
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21405
Ere Maijala changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 15:19:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 14:19:59 +0000
Subject: [Koha-bugs] [Bug 21084] Searching for authorities with 'contains'
gives no results if search terms include punctuation
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21084
Ere Maijala changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |ere.maijala at helsinki.fi
Assignee|koha-bugs at lists.koha-commun |ere.maijala at helsinki.fi
|ity.org |
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 15:42:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 14:42:05 +0000
Subject: [Koha-bugs] [Bug 19489] Development for fines and Fees Module -
Detailed Description of charges in Patron Account Tab/Fines Tab
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489
--- Comment #11 from Devinim ---
(In reply to Owen Leonard from comment #9)
> This seems to be working, but the test doesn't pass:
>
> t/db_dependent/Koha/Account/Lines.t .. 1/5
> # Failed test 'No tests run for subtest "item() tests"'
> # at t/db_dependent/Koha/Account/Lines.t line 67.
> DBIx::Class::Storage::DBI::_dbh_execute(): Field 'account_balance' doesn't
> have a default value at /home/vagrant/kohaclone/t/lib/TestBuilder.pm line 288
> # Looks like your test exited with 255 just after 1.
> t/db_dependent/Koha/Account/Lines.t .. Dubious, test returned 255 (wstat
> 65280, 0xff00)
> Failed 5/5 subtests
>
> Test Summary Report
> -------------------
> t/db_dependent/Koha/Account/Lines.t (Wstat: 65280 Tests: 1 Failed: 1)
> Failed test: 1
> Non-zero exit status: 255
> Parse errors: Bad plan. You planned 5 tests but ran 1.
> Files=1, Tests=1, 3 wallclock secs ( 0.01 usr 0.01 sys + 1.21 cusr 0.52
> csys = 1.75 CPU)
> Result: FAIL
We applied the test on the latest provisioned kohadevbox environment and we
found that there are some changes to pay.tt .
When we changed pay.tt manually we passed dependency test as you may see below.
prove t/db_dependent/Koha/Account/Lines.t
t/db_dependent/Koha/Account/Lines.t .. ok
All tests successful.
Files=1, Tests=5, 5 wallclock secs ( 0.03 usr 0.01 sys + 3.90 cusr 0.66
csys = 4.60 CPU)
Result: PASS
How did you get your errors?
Thanks,
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 15:49:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 14:49:40 +0000
Subject: [Koha-bugs] [Bug 21933] Renew or chek in selected items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21933
--- Comment #5 from Katrin Fischer ---
I meant the Koha version - you listed it above as master, which is unlikely.
The exact version is listed on the first tab of the About page.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 15:56:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 14:56:22 +0000
Subject: [Koha-bugs] [Bug 21875] Handling subject line in Letters.pm
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21875
--- Comment #4 from Marcel de Rooy ---
Created attachment 82840
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82840&action=edit
Bug 21875: Handling subject line in Letters.pm
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 15:57:53 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 14:57:53 +0000
Subject: [Koha-bugs] [Bug 21875] Handling subject line in Letters.pm
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21875
--- Comment #5 from Marcel de Rooy ---
Test plan (Bugzilla only to prevent git bz encoding stuff):
[1] Make Koha send a queue message with a plain ASCII subject line. Verify the
subject line at the receiving side.
Possible in many ways. Here is one: Enable list sharing and send a share
invitation on a list with a plain ASCII text name like "L2".
[2] Now send a subject line with some Latin chars. Verify.
Rename your list L2 from step 1 to L2???. Send another share invitation.
[3] Now send a subject line with some 'real' Unicode chars. Verify.
Rename L2??? to L2?????. Repeat the invite.
[4] Now include MIME encoding in the list name. (To make Martin happy ;)
Verify.
Rename L2????? to =?UTF-8?B?IHBlcmwgSsO8?= (include the equal signs)
Since I gave the list a strange and ugly name, I would like to see that name in
the subject line. (You will also see it in the message body.)
Note: Without this patch the subject line is decoded to "Share list perl J?".
This is wrong, because it is not my list name!
Bonus: Try some other email address/mail program too.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 15:58:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 14:58:47 +0000
Subject: [Koha-bugs] [Bug 21875] Handling subject line in Letters.pm
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21875
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
Patch complexity|--- |Small patch
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 15:58:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 14:58:50 +0000
Subject: [Koha-bugs] [Bug 21875] Handling subject line in Letters.pm
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21875
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #82601|0 |1
is obsolete| |
Attachment #82840|0 |1
is obsolete| |
--- Comment #6 from Marcel de Rooy ---
Created attachment 82841
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82841&action=edit
Bug 21875: Handling subject line in Letters.pm
The variable name $utf8 is very misleading: it contains MIME-Header encoding.
$message->{subject} comes from the database and is in perl internal format;
it should NOT be decoded as a MIME-Header.
After encoding to MIME-Header, previously another (useless) encoding to
UTF-8 was done. Since the string is plain ASCII, this is useless and
theoretically wrong. We should stay in MIME-Header.
Test plan:
See Bugzilla comment5.
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 15:59:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 14:59:09 +0000
Subject: [Koha-bugs] [Bug 15422] Number of items to order on holds ratio
report will not fulfill the holds ratio.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15422
--- Comment #3 from Nick Clemens ---
Created attachment 82842
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82842&action=edit
Bug 15422: Consider partial copies needed as whole numbers
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 15:59:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 14:59:14 +0000
Subject: [Koha-bugs] [Bug 21933] Renew or chek in selected items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21933
sergeinik changed:
What |Removed |Added
----------------------------------------------------------------------------
Version|master |18.11
--- Comment #6 from sergeinik ---
Sorry. 18.11.00.000
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 15:59:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 14:59:22 +0000
Subject: [Koha-bugs] [Bug 21875] Handling subject line in Letters.pm
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21875
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Component|Notices |Architecture, internals,
| |and plumbing
Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
|ity.org |
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 16:01:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 15:01:15 +0000
Subject: [Koha-bugs] [Bug 21941] New: Incorrect GROUP BY in
circ/reserveratios.pl
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21941
Bug ID: 21941
Summary: Incorrect GROUP BY in circ/reserveratios.pl
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Circulation
Assignee: koha-bugs at lists.koha-community.org
Reporter: nick at bywatersolutions.com
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
DBD::mysql::st execute failed: 'koha_kohadev.reserves.reservedate' isn't in
GROUP BY [for Statement "SELECT reservedate,
reserves.borrowernumber as borrowernumber,
reserves.biblionumber,
reserves.branchcode as branch,
items.holdingbranch,
items.itemcallnumber,
items.itemnumber,
GROUP_CONCAT(DISTINCT items.itemcallnumber
ORDER BY items.itemnumber SEPARATOR '|') as listcall,
GROUP_CONCAT(DISTINCT homebranch
ORDER BY items.itemnumber SEPARATOR '|') as homebranch_list,
GROUP_CONCAT(DISTINCT holdingbranch
ORDER BY items.itemnumber SEPARATOR '|') as holdingbranch_list,
GROUP_CONCAT(DISTINCT items.location
ORDER BY items.itemnumber SEPARATOR '|') as l_location,
GROUP_CONCAT(DISTINCT items.itype
ORDER BY items.itemnumber SEPARATOR '|') as l_itype,
reserves.found,
biblio.title,
biblio.author,
count(DISTINCT reserves.borrowernumber) as reservecount,
count(DISTINCT items.itemnumber) as itemcount
FROM reserves
LEFT JOIN items ON items.biblionumber=reserves.biblionumber
LEFT JOIN biblio ON reserves.biblionumber=biblio.biblionumber
WHERE
notforloan = 0 AND damaged = 0 AND itemlost = 0 AND withdrawn = 0
AND reservedate >= ? AND reservedate <= ?
GROUP BY reserves.biblionumber ORDER BY reservecount DESC" with ParamValues:
0='2017-12-04 00:00', 1='2018-12-04 00:00'] at
/home/vagrant/kohaclone/circ/reserveratios.pl line 150.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 16:01:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 15:01:46 +0000
Subject: [Koha-bugs] [Bug 21875] Handling subject line in Letters.pm
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21875
--- Comment #7 from Marcel de Rooy ---
Martin,
Please check the fourth step in the test plan on comment5. Hope it does better
explain my point of view.
Thanks,
Marcel
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 16:01:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 15:01:50 +0000
Subject: [Koha-bugs] [Bug 21941] Incorrect GROUP BY in circ/reserveratios.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21941
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=15422
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 16:01:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 15:01:50 +0000
Subject: [Koha-bugs] [Bug 15422] Number of items to order on holds ratio
report will not fulfill the holds ratio.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15422
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=21941
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 16:12:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 15:12:48 +0000
Subject: [Koha-bugs] [Bug 20551] Add option for including deleted records in
export_records.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551
David Gustafsson changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #75113|0 |1
is obsolete| |
--- Comment #6 from David Gustafsson ---
Created attachment 82843
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82843&action=edit
Bug 20551: Add option for including deleted records in export_records.pl
Add option "--include_deleted" to include deleted
biblios in export_records.pl as marc records with
record status (in leader) set to "d" and
"--deleted_only" to export only deleted biblios.
How to test:
1) Run tests in t/db_dependent/Exporter/Record.t
2) All tests should pass
3) Delete a biblio record in Koha
4) Run the export script as:
`export_records.pl --date=
--include_deleted`
5) Open the generated koha.mrc, and verify that contains
the recently deleted record, and that the record header
has record status "d".
6) Perform the same check with:
`export_records.pl --date=
--include_deleted --format=xml`
7) Run:
`export_records.pl --date=
--deleted_only --format=xml`
and verify that only the deleted biblio was included
in the export.
Sponsored-by: Gothenburg University Library
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 16:14:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 15:14:51 +0000
Subject: [Koha-bugs] [Bug 20551] Add option for including deleted records in
export_records.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551
--- Comment #7 from David Gustafsson ---
Rebase against master (untested, will test later and verify that still works).
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 16:28:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 15:28:37 +0000
Subject: [Koha-bugs] [Bug 21933] Renew or chek in selected items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21933
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |INVALID
--- Comment #7 from Owen Leonard ---
(In reply to sergeinik from comment #2)
> checkouts_18.1100000.js:310
Line 310 of checkouts.js is where an item's home library is displayed, so it
sounds like you have one or more items with a null value in items.homebranch.
I think the script skips error-checking for this value because it is expected
that all items will have a value in items.homebranch -- Koha requires it for
circulation.
I'm marking this bug "invalid" because this is really a data problem instead of
a bug, but it would be worthwhile for us to include error-checking even for
values which are mandatory.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 16:32:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 15:32:05 +0000
Subject: [Koha-bugs] [Bug 21942] New: Clean up cataloging merge template
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21942
Bug ID: 21942
Summary: Clean up cataloging merge template
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: ASSIGNED
Severity: enhancement
Priority: P5 - low
Component: Templates
Assignee: oleonard at myacpl.org
Reporter: oleonard at myacpl.org
QA Contact: testopia at bugs.koha-community.org
There are a few minor markup issues with the cataloging merge template.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 16:36:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 15:36:54 +0000
Subject: [Koha-bugs] [Bug 20535] ModZebra called with $record with items
stripped in ModBiblioMarc
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20535
David Gustafsson changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #73755|0 |1
is obsolete| |
--- Comment #2 from David Gustafsson ---
Created attachment 82844
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82844&action=edit
Bug 20535: ModZebra called with $record with items stripped
ModZebra called with $record with items stripped in
ModBiblioMarc. Remove $record argument to force
record to be loaded again from database with items
embedded.
How to test:
1) Make sure biblios are indexed (with
rebuild_elastic_search.pl).
2) Perform a search that will produce a sample result
containing at least one biblio with items.
3) Edit and save a biblio with items.
4) Perform the same search again, the updated biblio
should now have no items when viewed in the search
results (No items).
5) Apply patch.
6) Repeat step 1-3.
7) The updated biblio should now have items when viewed
in the search results.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 16:37:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 15:37:18 +0000
Subject: [Koha-bugs] [Bug 20535] ModZebra called with $record with items
stripped in ModBiblioMarc
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20535
--- Comment #3 from David Gustafsson ---
Rebased against master.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 16:41:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 15:41:31 +0000
Subject: [Koha-bugs] [Bug 21942] Clean up cataloging merge template
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21942
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Trivial patch
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Dec 4 16:41:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Dec 2018 15:41:34 +0000
Subject: [Koha-bugs] [Bug 21942] Clean up cataloging merge template
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21942
--- Comment #1 from Owen Leonard ---
Created attachment 82845
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82845&action=edit
Bug 21942: Clean up cataloging merge template
This patch makes a few minor markup corrections to the cataloging merge
template:
- Remove invalid "type" attributes from