[Koha-bugs] [Bug 21849] Offsets not stored correctly in _FixOverduesOnReturn
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Thu Dec 6 17:03:08 CET 2018
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21849
--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 82920
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82920&action=edit
Bug 21849: Two useless Koha::Account::Offset->new calls need attention
Came across those calls in bug 20598 in _FixOverduesOnReturn
Koha::Account::Offset->new(
{
debit_id => $accountline->id,
type => 'Forgiven',
amount => $amountoutstanding * -1,
}
);
This does nothing if you don't store data.
Test Plan:
1) Apply this patch
2) Set up 2 items with overdue fines
3) Return one with dropbox mode
4) Note the dropbox account offset is created
5) Return one with full fine forgiveness
6) Note the forgiven account offset is created
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list