[Koha-bugs] [Bug 21716] Item Search hangs when \ exists in MARC fields

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21716

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
             Status|Signed Off                  |Failed QA

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Martin Renvoize from comment #5)
> This works as expected and is a helpful addition... I've tested it and am
> signing off.
It doesn't work for me. The page loads, yes. But publisher and publication year
have disappeared.

> QA Note.. this is sort of horrible, that's we're generating JSON by passing
> it through a template.. but that's how it currently is and it would be a
> fairly major refactor to undertake for such a minor fix.
I agree this is horrible, and I'm the one responsible for it :)
When I wrote the patch, I believed it was the only way to have translatable
strings in a server-side Datatable setup.
Fortunately I was wrong, and we can make use of the datatable's 'mRender'
option to separate the data (what should be returned in the JSON response) from
the rendered html (which should contain translated strings)
It does not require a big refactor. I will submit a patch soon.

-- 
You are receiving this mail because:
You are watching all bug changes.