[Koha-bugs] [Bug 11492] Receiving a serial item causes routing list notes to be lost

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11492

--- Comment #6 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
(In reply to Jonathan Druart from comment #5)
> Hi Aleisha,
> 
> You are doing things that are not advertised in the commit message. For
> instance you are passing $publisheddatetext to NewIssue. I feel like this is
> wrong, $publisheddatetext should not be kept from one issue to another.
> 
> There is
> 1160         my $nextpublisheddate = GetNextDate($subscription,
> $publisheddate, 1);
> 1161         my $nextpubdate = $nextpublisheddate;
> 
> And $nextpubdate is passed as $planneddate and $publisheddate for the next
> one, but $publisheddatetext will be unchanged.

Hi Jonathan,
I only did this because the subroutine already took $publisheddatetext as a
parameter, so thought it would be okay. I will resubmit my patch with an empty
string in the place of $publisheddatetext, but otherwise this seems like a
different problem.

-- 
You are receiving this mail because:
You are watching all bug changes.