[Koha-bugs] [Bug 19489] Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489

--- Comment #18 from Devinim <kohadevinim at devinim.com.tr> ---
(In reply to Jonathan Druart from comment #16)
> 2. As well, the html filter is not needed when already KohaDates filtered.
> 
> 3. in printinvoice.pl
> 
> +$accountline->{'item'} = $accountline->{itemnumber} ?
> $accountline_object->item : "" ;
> +$accountline->{'issue'} = $accountline->{issue_id} ?
> $accountline_object->issue : "" ;
> 
> It read wrong, why not:
>   $accountline->{item} = $accountline_object->item || "" ;
>   $accountline->{issue} = $accountline_object->issue || "";
> ?

2. As similar to answer 1, some other files also use html filter like
reserve/request.tt
catalogue/issuehistory.tt


3. If you choose Create manual invoice tab and then select a type without using
a barcode number (like New Card), since there won't be an itemnumber in
accountline table, item object will give an error like (  DBIC result _type
isn't of the _type Item at /home/vagrant/kohaclone/members/printinvoice.pl line
60) .

-- 
You are receiving this mail because:
You are watching all bug changes.