[Koha-bugs] [Bug 21999] C4::Circulation::AddIssue uses DBIx::Class directly

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Dec 14 16:22:52 CET 2018


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21999

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
So.. this is a bit of a 'quick fix'.. the long term we will likely want to
deprecate AddIssue and move it into Koha::*.. but, some places already expect
the returned value to be a Koha::Checkout so this is the patch I've come up
with.

Test plan.. the majority of places that call AddIssue do so in VOID context and
so this change of return value should not affect them.  Most cases where the
return value is used were in the tests and those have been updated in the
second patch... that just leaves `circ/circulation.pl` where the return is
passed into the template (and the Koha::Object should be seamless there).

Finally, SIP uses the returned value too but in such a way that the
Koha::Checkout being returned instead is also fine (as we only ever look at the
date_due field).

To Test.. apply patches.. run the full test suit and everything should pass.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.


More information about the Koha-bugs mailing list