[Koha-bugs] [Bug 15326] Add CMS feature

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Dec 17 22:16:40 CET 2018


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78233|0                           |1
        is obsolete|                            |

--- Comment #48 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 83319
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83319&action=edit
Bug 15326: (follow-up) Add CMS feature

This patch builds on Martin Persson's patch. I made a few changes that
improve the patch and make this feature functional.
The only thing I am not completely satisfied with (and doesn't reliably
work) is the navigation for the CMS pages on both the staff side and the
OPAC side. This needs work. Otherwise the CMS feature works.

- Make sure you update database after applying patch
- After adding a few pages, confirm that filtering results works (play
 with different combinations of display location, library and language)
- Confirm that pages with specific locations ONLY show up in those
locations, i.e. OPAC pages can only be accessed in OPAC and staff interface
pages can only be accessed on staff client
- Confirm that table is showing correct data, particularly language,
location and library
- Confirm that if page has not been published and user does not have
permission to edit pages, page content will not display on OPAC side. On
staff side, a message will show saying that page has not been published
- Confirm pagination for table shows and works
- Confirm deleting pages works as expected (confirm message before
delete)
- Confirm link title must be unique when adding new pages
- Confirm that editing the details of an existing page works
- Confirm that adding a child page will only work if the location of
child page matches location of parent page, i.e., if parent page is an
OPAC page then child page must also be OPAC page. if parent page is in
all locations then child page can be in all or either interface(s)
- Confirm Select All/Clear All toggle works
- Confirm viewing of CMS pages in OPAC and in staff client works and
looks nice

Sponsored-by: Region Halland

Bug 15326: [FOLLOW-UP] Many fixes

This patch:
- moves action buttons into a dropdown, adds a delete button to dropdown
- fixes the tests (they should now all pass)
- fixes qa tool problems
- removes the Koha::CmsPages->remove() method (unnecessary)
- makes changes to the Koha::CmsPages->add() method (now simpler, easier
to test)

This is now ready to test.

Sponsored-by: Catalyst IT

Bug 15326: [FOLLOW-UP] More fixes

This patch removes the t/Pages.t file because it isn't required, and
other unused methods.

This patch is ready to test. The appropriate tests are in
t/db_dependent/Pages.t

Bug 15326: [FOLLOW-UP] adding and editing fixes

Sorry, did not see the second half of your comment. This patch should
fix the adding and editing issues in Comment 16.

Bug 15326: [FOLLOW-UP] Fixing library field in form, opac publishing

Fixes issues from Comment 19, please test

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list