[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Dec 18 03:20:30 CET 2018


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565

--- Comment #188 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Created attachment 83342
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83342&action=edit
Bug 15565: (follow-up) Changes to maximum hold allowed logic

Implemented changes to the logic to address Katrin Fischer's points in
comment #175, also changed the modal box wording to use 'hold' not
'reserve'

Also updated t/db_dependent/Reserves/MultiplePerRecord.t test to reflect
moving function.

Added the display of the JS modal box informing OPAC borrower that
they have exceeded hold limit after they click 'A specific item'
radiobutton on opac-reserve if holds per day, holds per record or
maxreserves is 1

Test plan:
1. Apply patches
2. Restart memcached and plack
3. Run t/db_dependent/Reserves/MultiplePerRecord.t
4. Set your maxreserves syspref to 3, and a circ rules holds per record
to 2 and holds per day to 1
5. In the OPAC visit the 'Place hold' interface of item. Select the 'A
specific item' radiobutton and observe the first item checkbox is
checked and other unchecked checkboxes are disabled.
6. Repeat step 4 this time setting holds per day to 5
7. Now reloading the OPAC 'Place hold' page notice after clicking 'A
specific item' no modal displays
8. Select a second item checkbox and observe a modal saying you have reached
the maximum number of holds for the record is loaded - notice the
wording 'hold' not 'reserve' in use in the modal box
9. Click 'OK' on modal and observe all unchecked item checkboxes are
automatically disabled to prevent additional holds being placed
10. Select 'Confirm hold'
11. On your holds summary page confirm both holds are placed
12. In the staff client set the 'AllowHoldPolicyOverride' syspref to
"Don't allow"
13. Visit a biblio reservation interface in the staff client
14. Select 2 item checkboxes and observe the modal box explaining you
have reached maximum holds for the record is displayed - notice the
wording of 'hold' not 'reserve' is used in the modal box.
15. Select 'OK' on the modal and notice all un-checked item checkboxes
are automatically disabled
16. Repeat steps 12-15 this time with the value of
'AllowHoldPolicyOverride' syspref set to 'Allow' and notice that once
you have clicked on the second item checkbox although the modal still
loads the item checkboxes do not disable - you are able to override and
continue selecting checkboxes each time with modal warning loading.

17. In both the OPAC and staff client try placing a record level hold,
selecting a value from the 'Holds to place (count)' dropdown. Notice
that the maximum value of this is the lowest value out of the 'maximum
number of holds per record', 'maximum number of holds per day' and the
'maxreserves' system preference so in this case it will be 2
18. Save and notice 2 holds are placed

19. Observe the allow_holds() function is in the Koha/Biblio.pm file and
the GetAllowedHoldsForPatronToday() function has been removed from
C4/Reserves.pm

Sponsored-By: Brimbank Library, Australia

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list