[Koha-bugs] [Bug 21877] Show authorized value description for withdrawn in checkout

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Dec 18 10:44:14 CET 2018


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877

--- Comment #4 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
(In reply to Jonathan Druart from comment #3)
> Why are not you doing it the same way as notforloan?
> 
> Or provide tests, but I'd prefer consistency...

In Circulation.pm its the same :
  $needsconfirmation{item_notforloan} = $item->{'notforloan'};
  $issuingimpossible{item_withdrawn} = $item->{'withdrawn'};

In circulation.tt :

notforloan uses AuthorisedValues.GetByCode( authvalcode_notforloan ...
authvalcode_notforloan is computed in circulation.pl
this useful because it is used several times in circulation.tt.

But for withdrawn the authorised value is used only once.
Using AuthorisedValues.GetDescriptionByKohaField is better for MVC separation
no ?

I could create another bug to change notforloan maybe ?

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list