[Koha-bugs] [Bug 22033] New: related_resultset is another whole in the Koha::Object logic

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Dec 20 17:57:38 CET 2018


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22033

            Bug ID: 22033
           Summary: related_resultset is another whole in the Koha::Object
                    logic
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

related_resultset is in the known_methods array and as such is allowed to be
called via any existing Koha::Object result.

This method is untested (I thought all methods being passed through required
full testing koha side.. at least that's what I had been lead to beleive).

This method returns a DBIx::Class::ResultSet and not a Koha::Objects result
class and as such introduces inconsistent behaviour.. we should have it remain
consistent and have a localised method to convert the result to a Koha::Object
derived class..

Personally, one of my biggest disappointments with Koha::Objects is that we
don't get the relationship accessors provided by DBIx::Class

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.


More information about the Koha-bugs mailing list